Looks good to me Dermot
On 14/09/2011 21:24, Dermot McCluskey wrote: > John, Mary, Darren, > > Please let me know if you have any further comments. > Otherwise, I'll push this tomorrow. > > - Dermot > > > On 9/14/2011 2:24 PM, Dermot McCluskey wrote: >> Dave, >> Can I get approval to also push the fix for >> http://monaco.sfbay.sun.com/detail.jsf?cr=7090463 >> gui-install package should depend on system/install/locale >> (which is the GUI Install portion of bug 7072062) along >> with this fix, as requested by Mary? >> >> Mary, >> I've opened a new bug to track the gui-install portion >> of 7072062 and will push the fix you suggested along with >> this, pending approval. >> The fix is in the updated webrev, below. >> >> John, >> Thanks for spotting that. en_US-UTF.8 should be en_US.UTF-8 >> (swap "-" and ".") That line was already in the manifest and was >> unchanged by me. It presumably went unnoticed because if >> that dir is not found, it falls back to C, which is what it was >> linking to anyway. I've fixed that in the new webrev, below. >> >> New webrev: >> https://cr.opensolaris.org/action/browse/caiman/dermot/7089656-2/ >> >> Incremental webrev, round #1 to round #2: >> https://cr.opensolaris.org/action/browse/caiman/dermot/7089656-2-incremental/ >> >> >> >> Additional testing done: >> 7090463: Checked the Manifest on an IPS server serving >> my slim_source build, before and after; also did: >> $ pkg search -l 'depend:system/install/locale' >> in LiveCD environment before and after, confirming that >> dependency on system/install/locale has been added. >> 7089656: Built LiveCD and confirmed that en_US.UTF-8 >> link is now correctly created. >> >> - Dermot >> >> >> >> On 09/13/11 21:43, John Fischer wrote: >>> Dermot, >>> >>> Thanks for the link. Everything looks great except I am concerned >>> about: >>> >>> 143 link path=usr/share/gui-install/installmessages/en_US-UTF.8 >>> target=C >>> 144 dir path=usr/share/gui-install/installmessages/es_ES.UTF-8 >>> group=sys >>> >>> This is from the manifest file. >>> >>> Thanks, >>> >>> John >>> >>> On 09/13/11 01:28 PM, Dermot McCluskey wrote: >>>> Ah - I forgot to add the webrev link ;( >>>> >>>> https://cr.opensolaris.org/action/browse/caiman/dermot/7089656/ >>>> >>>> (I made the comment about webrev/png files to explain the error >>>> messages in the webrev, and then forgot the link) >>>> >>>> - Dermot >>>> >>>> >>>> >>>> On 9/13/2011 8:47 PM, Darren Kenny wrote: >>>>> Hi Dermot, >>>>> >>>>> In what way does webrev complain? I seem to remember that doing a >>>>> change like >>>>> this would just result in a "file changed" type entry, and you >>>>> could look at the >>>>> 'new' link to see the raw png file. >>>>> >>>>> It would be good to at least maybe serve out the workspace using >>>>> 'hg serv' some >>>>> where so people could look at the changeset in mercurial directly... >>>>> >>>>> Hard to review it without seeing anything at all ;) >>>>> >>>>> Thanks, >>>>> >>>>> Darren. >>>>> >>>>> On 13/09/2011 18:27, Dermot McCluskey wrote: >>>>>> Hi, >>>>>> >>>>>> Can I get a couple of reviewers for this approved >>>>>> fix for 175? >>>>>> >>>>>> http://monaco.sfbay.sun.com/detail.jsf?cr=7089656 >>>>>> RFE: need i18n splash screen images integrated into FCS bits >>>>>> >>>>>> Details: >>>>>> No code changes - just dropping in updated and new >>>>>> .png files, plus associated changes to Makefiles >>>>>> and manifest file. (Webrev doesn't like .png files - is there >>>>>> a way to tag these as binary files in hg?) >>>>>> >>>>>> Testing: >>>>>> Built LiveCD ISO and started install in all 10 supported >>>>>> locales and confirmed that the correct 6 images for >>>>>> that locale are displayed during the install. >>>>>> >>>>>> - Dermot >>>>>> >>>>>> _______________________________________________ >>>>>> caiman-discuss mailing list >>>>>> [email protected] >>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> [email protected] >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
