On 09/13/11 02:42 PM, John Fischer wrote:
Karen,

It is my understanding that in the near future this file will point
to appropriately localized pages.
ah, ok, in that case, it makes sense to have them separate then.

Thanks for the explanation John.

--Karen


Thanks,

John

On 09/13/11 02:38 PM, Karen Tung wrote:
Hi Dermot,

The "imageurl.txt" file in each of the locale related subdirectories
appears to contain identical information.  Does it make sense
to just keep 1 copy of the file somewhere and have the Makefile
"install" it to the appropriate place?  That way, in the future,
if we want to change any of the links inside the file, we don't need to
change multiple files.

Thanks,

--Karen
*
*On 09/13/11 01:28 PM, Dermot McCluskey wrote:
Ah - I forgot to add the webrev link ;(

https://cr.opensolaris.org/action/browse/caiman/dermot/7089656/

(I made the comment about webrev/png files to explain the error
messages in the webrev, and then forgot the link)

- Dermot



On 9/13/2011 8:47 PM, Darren Kenny wrote:
Hi Dermot,

In what way does webrev complain? I seem to remember that doing a change like this would just result in a "file changed" type entry, and you could look at the
'new' link to see the raw png file.

It would be good to at least maybe serve out the workspace using 'hg serv' some
where so people could look at the changeset in mercurial directly...

Hard to review it without seeing anything at all ;)

Thanks,

Darren.

On 13/09/2011 18:27, Dermot McCluskey wrote:
Hi,

Can I get a couple of reviewers for this approved
fix for 175?

http://monaco.sfbay.sun.com/detail.jsf?cr=7089656
RFE: need i18n splash screen images integrated into FCS bits

Details:
No code changes - just dropping in updated and new
.png files, plus associated changes to Makefiles
and manifest file. (Webrev doesn't like .png files - is there
a way to tag these as binary files in hg?)

Testing:
Built LiveCD ISO and started install in all 10 supported
locales and confirmed that the correct 6 images for
that locale are displayed during the install.

- Dermot

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to