Kristina,
This LGTM!
-Drew
On 9/20/11 8:36 PM, Kristina Tripp wrote:
Good Evening. Please find an initial review the following changes
that I've been given tentative approval for. I'm sending this out now
despite testing being incomplete since I've been asked to have this
completed by COB tomorrow and the primary reviewers are in Prague.
https://cr.opensolaris.org/action/browse/caiman/enpointe/CR7092529/webrev/
7091163 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7091163> js2ai should set
name of<ai_instance name=""> to profile name instead of default
7091196 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7091196>
js2ai not processing filesys swap entry correct - vdev entry omitted
7092486 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7092486>
install/js2ai has incorrect license
7092529 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7092529>
js2ai - DNS conversion in sysidcfg is incorrect
7091377 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7091377>
SC profile generated by js2ai(1m) tool does not configure some parameters correctly
Profile changes in conv.c were tested via Harold during some testing
earlier in the week
Testing of the changes in conv_sysidcfg.c is incomplete at this point
in time as I'm hoping William and/or Jan can test these changes for me
Testing a package install to ensure license info is installed properly
is still outstanding
Unit test all pass
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
