On 11/02/11 15:11, John Fischer wrote:
Ethan,
See comments below.
John
On Nov 2, 2011, at 2:47 PM, Ethan Quach wrote:
test_aimdns_manual.py:
-------------------------------
88-94 - Any reason why this comment chunk can't be chucked?
Removed. Added the following comment prior to the Register() call:
# Use "dns-sd -B _OSInstall._tcp local" to monitor Addition and
# Removal of services.
Couldn't /usr/lib/installadm/aimdns.py be used here instead? But in either
case, I'm not quite getting what this comment meant to achieve?
The original comment was meant to help with debugging the test.
Using dns-sd, an unrelated tool, to monitor registrations is helpful
in that it completely removes any errors within the aimdns_mod.py
code while debugging. However, I can simply remove the comment
assuming that we can figure out how to debug the test.
I don't have any issues about leaving it in there, but if we leave it,
perhaps clarify it a little bit more with what you've described above.
And sorry for getting these questions to you piece-meal but I have
another one -- the comment at lines 26-27. Since, we're effectively
removing the 120 second timeout from this test code, could this whole
test module now be an automated unit test, or are there other issues?
-ethan
178 - Since we're not using dns-sd in this test code to publish anymore, does
this comment need to be updated as well?
Changed from:
177 '''Verify a unique service shows up for all interfaces listed
178 (since dns-sd publishes on all iterfaces) when doing an
179 AImDNS().browse()
To:
177 '''Verify a unique service shows up for all interfaces listed
178 when doing an AImDNS().browse()
That should be the last reference to dns-sd.
thanks,
-ethan
131 - Seems like this comment needs to be updated.
Changed to:
Use the AImDNS class to create a fake mdns service.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
