All,
After some off line discussion with Ethan and Dave I have modified
the fix to include updates to the aimdns tests. The updated webrev
is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7046264-aimdns-ttl-3/
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7046264-aimdns-ttl-diff-3/
Test results for the manual test are:
root@testhost:~/slim_source_aimdns/usr/src/tools/tests# slim_test
-c tests.nose 2148 2149 2150 2151
#2148 Test that AImDNS().browse returns True upon finding a
service ... ok
#2149 Test AImDNS().find() returns True when service is found and
False ... ok
#2150 Verify a unique service shows up for all interfaces listed
... ok
#2151 Test the AImDNS().register() method ... ok
----------------------------------------------------------------------
Ran 4 tests in 28.648s
OK
Test results for the non-manual tests are:
root@testhost:~/slim_source_aimdns/usr/src/tools/tests#
./slim_test -c tests.nose cmd/installadm/test/test_aimdns.py
#862 test browse callback ... ok
#863 test compare_ipv4 returns valid results ... ok
#864 test _convert_cidr_mask returns something reasonable ... ok
#865 test in_network returns valid results ... ok
#866 test registration callback output ... ok
----------------------------------------------------------------------
Ran 5 tests in 1.026s
OK
This round includes the updates for Dave's original questions about
comments and the removal of flags from the DNSServiceUpdateRecord()
call.
Thanks,
John
On 10/27/11 04:18 PM, John Fischer wrote:
Dave,
The updated webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7046264-aimdns-ttl-2/
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7046264-aimdns-ttl-diff/
Answers to questions below.
Thanks,
John
On 10/18/11 03:14 PM, Dave Miner wrote:
I'd ask only that you add a comment here noting what's going on
(perhaps explain why flags=0, ttl=10 are the right values).
I have updated the DNSServiceUpdateRecord() call without the
flags as it is not necessary. I've also added the below comment:
# DNSServiceUpdateRecord will update the default record if
# RecordRef is None. Time-to-live (ttl) for the record
is being
# set to 10 seconds. This value allows enough time for the
# record to be looked up and it is short enough that
when the
# service is deleted then the mdns daemon will remove it
from
# the cache after the this value but prior to another
service
# with the same name being created.
pyb.DNSServiceUpdateRecord(sdRef=sdref, RecordRef=None,
rdata=text, ttl=10)
I have created a service that requires the compatibility
port number (465##), deleted the service and recreated
the service with a newer install image not requiring a
compatibility port number. All tests worked fine.
Unit tests run, or need updating?
The tests do need updating and that is being tracked in
CR 7000918. Unit tests were run. The full tests were
also run with 2 unrelated failures. I pulled out the ones
relevant to aimdns below:
root@testhost:~/slim_source_aimdns/usr/src/tools/tests# ./slim_test
-c tests.nose 862 863 864 865 866
#862 test browse callback ... ok
#863 test compare_ipv4 returns valid results ... ok
#864 test _convert_cidr_mask returns something reasonable ... ok
#865 test in_network returns valid results ... ok
#866 test registration callback output ... ok
----------------------------------------------------------------------
Ran 5 tests in 1.053s
OK
root@testhost:~/slim_source_aimdns/usr/src/tools/tests# ./slim_test
cmd/installadm/test/manual/
#2148 Test that AImDNS().browse returns True upon finding a service
... ok
#2149 Test AImDNS().find() returns True when service is found and
False ... ok
#2150 Verify a unique service shows up for all interfaces listed ... ok
#2151 Test the AImDNS().register() method ... ok
----------------------------------------------------------------------
Ran 4 tests in 251.362s
OK
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
