Karen,
See my comments in-line regarding the items Niall deferred to me.
On 12/23/11 11:26 AM, Karen Tung wrote:
> usr/src/cmd/text-install/disk_window.py
line 227: why not have this line immediately after line 223, in the else
block? Since it's obvious that we do not have gpt data at that point.
Done.
line 355: I noticed that the check to make sure
that get_parts_in_use() always return a list with length bigger
than 0 is removed. (eg: lines 322-323 in the original code).
I removed the check because of the old comment:
322 if len(data) == 0:
323 return # should never be this case
Why even have the check if it can't happen? If you feel that it's still
required, I can re-add it.
> usr/src/cmd/text-install/ti_target_utils.py
Some of the comments in the newly added UIGPTPartition() class
still talks about slices, I guess left over from copy-and-paste. :-)
:) Fixed!
Thanks for looking, Karen!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
