On 12/28/11 09:57 AM, Drew Fisher wrote:
On 12/28/11 10:55 AM, Karen Tung wrote:
Hi Drew,
On 12/28/11 08:11 AM, Drew Fisher wrote:
line 355: I noticed that the check to make sure
that get_parts_in_use() always return a list with length bigger
than 0 is removed. (eg: lines 322-323 in the original code).
I removed the check because of the old comment:
322 if len(data) == 0:
323 return # should never be this case
Why even have the check if it can't happen? If you feel that it's
still required, I can re-add it.
I guess I am OK either way. I forgot why I have it there originally.
I asked because I see that the check still exists in some other places
in the file, including the code you newly added. So, I thought we
can keep
it for consistency. Or remove it all for consistency. :-)
Ok, I'll remove things like this:
else:
if not data:
# should never be this case
return
and
else:
# Should never be this case
raise RuntimeError("Unable to find ui_obj or disk_info")
Are you OK with that?
-Drew
Sounds good to me...
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
