Hi Geoffrey,
You didn't say explicitly in your list of testing done.
Can confirm that the following testing was done?
1) Build all the DC ISOs with the updated manifests?
2) Perform GUI and text install with the ISO built from the updated
manifests.
General Comments:
1) I see that you updated both bugs with the diff output of the changes.
For those people that are not familiar with the code or those who don't
want to read the
code to understand what was changed, it would be very useful to write a
few sentences
explaining what the solution is.
2) The changes in this code review seem to address bug 7010088. How is
bug 7092487 addressed with these changes?
3) For 7010088, I thought we just want to print warnings if a file in
the list
of files to be CPIO-ed during DC is not found. We do not want to abort the
DC build. However, the changes added argument "fatal_if_not_found=true"
to all the DC manifests.
usr/src/lib/install_transfer/cpio.py:
- I don't see any code that interprets the argument fatal_if_not_found,
and set
the self.fatal_fail variable in this file. Where is that code?
- Since we want to quit if self.fatal_fail is true. Why not check for
self.fatal_fail
at line 301 and fail immediately? Why waste time to copy all the other
files if we will
fail eventually?
Thanks,
--Karen
On 01/23/12 09:10, Geoffrey Hart wrote:
Happy Monday all!
Could I please have a code review for:
7010088 transfer-cpio should abort when a file to be transferred
is not found
7092487 cpio transfer errors are not detected or reported
https://cr.opensolaris.org/action/browse/caiman/ghart/transferFixes/webrev/
Testing done for this fix:
Confirmed that DC and the installers can correctly pass the new
parameter to CPIO.
Confirmed that DC still creates bootable ISOs with the new logic.
Confirmed the installers still complete successfully.
Confirmed that TransferCPIO will fail on missing files (if the input
bool is set).
Confirmed that CPIO copy failures will result in an exception.
Confirmed that new logic will still result in the same files being
copied. Thus the new logic didn't cull any of the expected files.
Thanks,
-Geoffrey
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
