I have an updated version of the webrev with all the requested changes applied. Any final comments would be appreciated.

Geoffrey

http://neba/code/transferFixes/webrev/



On 01/23/12 10:10, Geoffrey Hart wrote:
Happy Monday all!

Could I please have a code review for:

7010088 transfer-cpio should abort when a file to be transferred is not found
    7092487 cpio transfer errors are not detected or reported

https://cr.opensolaris.org/action/browse/caiman/ghart/transferFixes/webrev/



Testing done for this fix:

Confirmed that DC and the installers can correctly pass the new parameter to CPIO.
Confirmed that DC still creates bootable ISOs with the new logic.
Confirmed the installers still complete successfully.
Confirmed that TransferCPIO will fail on missing files (if the input bool is set).
Confirmed that CPIO copy failures will result in an exception.
Confirmed that new logic will still result in the same files being copied. Thus the new logic didn't cull any of the expected files.


Thanks,
-Geoffrey
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to