Hi Sreedhar.

Just curious:
What happens in the case where there is only a single pre-snv164 service? If the output is OK then code LGTM.

    Thanks,
    Jack

On 01/30/12 00:58, Sreedhar Chalamalasetti wrote:
Hi

Could you please review the following fix

7120215 "installadm list -p" sometimes doesn't list service profiles

Webrev: https://cr.opensolaris.org/action/browse/caiman/sc157166/CR7120215/webrev/

Bug: If AI server contains Pre and Post snv164 services, then "installadm list -p" is not displaying profiles, even though post snv164 services have profiles. Pre snv164 build services did not have a profile table in its AT.db, the list code iterating through services to process the profile table quits when it finds a service with no profile table.

Solution: Instead of quits, it should skip those services that have no profiles and proceed further to check remaining services if exist.

Tests Performed:

    -Executed "installadm list -p" now showing profiles
    -Executed "installadm list -p  -n <svc_name>" also showing profiles.
    -pep8   - clean
    -slim_tests usr/src/cmd/installadm - Pass
    -Nightly completed successfully.

Thanks
Sreedhar


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to