Thanks, Sreedhar.
LGTM now.
Thanks,
Jack
On 01/30/12 23:33, Sreedhar Chalamalasetti wrote:
Jack / Darren
With my earlier fix, if no profiles exist against pre/post snv164
service, it is not giving the following message
"There are no profiles configured for local services."
So, I had slightly modified my fix, now it is giving correct results.
Please review the following webrev
https://cr.opensolaris.org/action/browse/caiman/sc157166/CR7120215_1
Tests Performed:
---------------------
1. only pre-snv164 service:
# installadm list
Service Name Alias Of Status Arch Image Path
------------ -------- ------ ---- ----------
snv_162 - on x86 /rpool/vms/services/snv_162
# installadm list -p
There are no profiles configured for local services.
2. pre and post snv164 services, but no profiles against any service:
# installadm list
Service Name Alias Of Status Arch Image Path
------------ -------- ------ ---- ----------
s11u1_05 - on x86 /rpool/vms/services/s11u1_05
snv_162 - on x86 /rpool/vms/services/snv_162
snv_169 - on x86 /rpool/vms/services/snv_169
snv_175 - on x86 /rpool/vms/services/snv_175
# installadm list -p
There are no profiles configured for local services.
3. profiles exist on post snv164 service:
# installadm list -p
Service Name Profile
------------ -------
snv_175 general
4. pep8, slim_test and nightly clean.
Thanks
Sreedhar
On 01/31/12 06:10, Sreedhar Chalamalasetti wrote:
Jack
If only single pre-snv164 service, then no output will return. That
means no profiles. And output is OK.
Thanks
Sreedhar
On 01/30/12 11:48 PM, Jack Schwartz wrote:
Hi Sreedhar.
Just curious:
What happens in the case where there is only a single pre-snv164
service? If the output is OK then code LGTM.
Thanks,
Jack
On 01/30/12 00:58, Sreedhar Chalamalasetti wrote:
Hi
Could you please review the following fix
7120215 "installadm list -p" sometimes doesn't list service profiles
Webrev:
https://cr.opensolaris.org/action/browse/caiman/sc157166/CR7120215/webrev/
Bug: If AI server contains Pre and Post snv164 services, then
"installadm list -p" is not displaying profiles, even though post
snv164 services have profiles. Pre snv164 build services did not
have a profile table in its AT.db, the list code iterating through
services to process the profile table quits when it finds a service
with no profile table.
Solution: Instead of quits, it should skip those services that have
no profiles and proceed further to check remaining services if exist.
Tests Performed:
-Executed "installadm list -p" now showing profiles
-Executed "installadm list -p -n <svc_name>" also showing
profiles.
-pep8 - clean
-slim_tests usr/src/cmd/installadm - Pass
-Nightly completed successfully.
Thanks
Sreedhar
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
