On 02/01/12 01:48, Matt Keenan wrote:
Karen,

Thanks for the review.

The first paragraph of the Evaluation was in response to this comment, indicating that the symlink is already being created by all three installers.
Hi Matt,

I see that you updated the evaluation today mentioning that the symlink is created by the solaris-package. I guess I was previously confused since it mentioned that the installers
are creating them.

Everything looks good to me now.

Thanks,

--Karen


Do you still feel I need to add more ?

cheers

Matt

On 01/30/12 18:12, Karen Tung wrote:
Hi Matt,

The code changes look good to me.

I have a question about Comment entry 1 that Dave made in the bug.
The comment talks about deliver /var/sadm/system/logs as a link to
/var/install/log.
I do not see any response to that comment or the code changes
implementing that.
Can you update the bug to talk about what you are doing for Dave's comment?

Thanks,

--Karen

On 01/30/12 09:50, Matt Keenan wrote:
Hi,

Can I get CR for following bug :
7130956 - Change default log location to /var/log/install
http://monaco.us.oracle.com/detail.jsf?cr=7130956

Webrev :
https://cr.opensolaris.org/action/browse/caiman/mattman/7130956/


This fix is a follow on from the recently integrated bug 7107775, and
turned out to be a lot less painful than envisioned, in fact rather
trivial.

Testing :
- Built all three ISOS ai/text/gui and test installed to ensure logs
are being installed to /var/log/install
- Ran complete set of unit tests and no regressions found.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to