Harold,
That is an excellent question. Ethan and I talked a little more in IRC
about what needs to
happen here. I am going to update the code review shortly. We are
separating out the
static stuff that gets copied and the dynamic stuff into /var/installadm
and /var/ai respectively.
Thanks for the review and stay tuned,
John
On 03/27/12 03:31 PM, Harold Shaw wrote:
Hi John,
The changes look fine. It seems as if it would have been simpler to
just exclude the files from being copied to the service directory but
I know that this has been discussed and I understand the desire to
physically separate the per-service files. I know that it's not part
of this fix but does it make sense to have everything pertaining to AI
under /var/ai instead of also having /var/installadm and /var/ai?
Harold
On 03/26/12 15:56, John Fischer wrote:
All,
Can I get a review of the fix for:
http://monaco.us.oracle.com/detail.jsf?cr=7130039
7130039 configuration files copied with each new service
The webrev can be found at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy/
The fix is to move the configuration files from /var/installadm to
/var/ai.
This involves changing more files than one might think as the build
environment, the installed tools and installation locations needed to
be modified.
The effected python file is pylint unchanged and pep8 clean. I have
ran slim_test and regression tests with copies located at:
http://xserver.us.oracle.com/~jfischer/slim_test-results.txt
http://xserver.us.oracle.com/~jfischer/regression-results.txt
I have also setup a new service and built an AI image. All tests
perform
as expected with no new regression reported from my changes.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
