Harold, Thanks for catching the "to to" nit.
I don't think that we need a doc update. John Sent from my iPad On Mar 30, 2012, at 9:05 AM, Harold Shaw <[email protected]> wrote: > Hi John, > It looks good. Just a question and a nit. > > ai_httpd.conf: > 20: s/to to/to/ > > Do the changes to ai_httpd.conf require any updates to the docs? > > Harold > > On 03/29/12 16:19, John Fischer wrote: >> All, >> >> Here is the second round for this code review. >> >> >> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy-2 >> >> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy-2-dif >> ** >> >> **Note: shows the addition of the libefi to the Targetsdirs file >> from Niall's push >> >> Ethan and I discussed the current solution. We decided to separate >> the static and dynamic content from each other. So now there are >> template directories for the services and the webserver. These get >> copied or symlinked from the /var/installadm directory structure to >> the /var/ai directory structure. >> >> I ran the same tests.... Still pep8 and pylint clean. I setup a new >> service and additionally tested to ensure that an existing service >> still worked. slim_test and regression tests were fine with nothing >> new. >> >> Thanks, >> >> John >> >> On 03/26/12 02:56 PM, John Fischer wrote: >>> All, >>> >>> Can I get a review of the fix for: >>> >>> http://monaco.us.oracle.com/detail.jsf?cr=7130039 >>> 7130039 configuration files copied with each new service >>> >>> The webrev can be found at: >>> >>> >>> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy/ >>> >>> The fix is to move the configuration files from /var/installadm to /var/ai. >>> This involves changing more files than one might think as the build >>> environment, the installed tools and installation locations needed to >>> be modified. >>> >>> The effected python file is pylint unchanged and pep8 clean. I have >>> ran slim_test and regression tests with copies located at: >>> >>> http://xserver.us.oracle.com/~jfischer/slim_test-results.txt >>> http://xserver.us.oracle.com/~jfischer/regression-results.txt >>> >>> I have also setup a new service and built an AI image. All tests perform >>> as expected with no new regression reported from my changes. >>> >>> Thanks, >>> >>> John >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
