Thanks, Drew! On Apr 11, 2012, at 10:02 PM, Drew Fisher wrote:
> LGTM! > > Thanks for working on the fix to this! > > -Drew > > > > On 4/11/12 7:58 PM, Jesse Butler wrote: >> Could I get a review for: >> >> 7150578 install discovery ignores device path lun numbers >> >> This CR is a small piece of the overall multipath target selection issue >> that the discovery code has. When we encounter multipath targets with MPxIO >> disabled, as is the default on SPARC, everything kind of falls apart. This >> is being worked separately. >> >> During that work, this bug was discovered. For each drive we discover, we >> retrieve a WWN. If the WWN name is found, we use it. We throw out subsequent >> drives with the same WWN. >> >> This is a problem in a few scenarios, most commonly when a RAID array is >> used. Most RAID arrays use the WWN of the HBA and a LUN number to identify a >> LUN. So, the current code will only discover one LUN per WWN, throwing away >> all the other LUNs using the same WWN. This could be the entire array on >> some configurations. Further, the ones that are put on the list are missing >> their LUN number. >> >> This changeset tacks the LUN number onto the end of the WWN string if it's >> in use, thus getting around the bad duplication avoidance, and setting a >> full WWN+LUN descriptor for each Disk object. >> >> https://cr.opensolaris.org/action/browse/caiman/jesseb/7150578/webrev/ >> >> Thanks >> Jesse >> >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
