Could I get another review for this? Thanks Jesse
On May 18, 2012, at 3:47 PM, Jesse Butler wrote: > > I had sent this out previously, but it got caught up in a bigger changeset > that looks like it needs some rework… so I'm back with just this one. > > https://cr.opensolaris.org/action/browse/caiman/jesseb/wwn_fix/webrev/ > > This changeset addresses two issues with how we deal with device WWNs during > discovery. > > The first issue is that currently we skip any device that has the same base > WWN as ones that we've seen already. In some storage configurations, it's > possible for all LUNs to share the same WWN. The way this code runs, for N > number of LUNs, we'd see only 1. Thus, we need to remove this skip. > > The second issue is that we only use the WWN for device identification, > rather than WWN + LUN, which is what's required when you have multiple LUNs > all sharing the same WWN. > > You could assume that with the second issue resolved, the first piece of code > (skip duplicates) could be left in place, since the strings will now have LUN > numbers and should be unique. I would agree, but that really shouldn't > happen. So, it's mostly cleanup. > > Speaking of cleanup, I'm also removing a check for WWN changing out from > under us, and also fixing a little typo bug. > > Thanks in advance, > Jesse > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
