I agree. I'll move the call into setUp().
Thanks, Jack!
-Drew
On 5/1/12 9:23 AM, Jack Schwartz wrote:
Hi Drew.
In test_distro_const.py, there is this:
355 dc.DC_LOGGER = logging.getLogger(INSTALL_LOGGER_NAME)
In other tests of this module, the logger is set up in setUp(), and is
set in self.logger, not dc.DC_LOGGER. Shouldn't this line be
consistent with other tests?
The rest LGTM.
Thanks,
Jack
On 05/ 1/12 06:13 AM, Drew Fisher wrote:
Good morning!
Could I please get a code review for the following bug:
7163019 <http://monaco.us.oracle.com/detail.jsf?cr=7163019> distro
name shouldn't be allowed to be blank
https://cr.opensolaris.org/action/browse/caiman/drewfish/7163019/webrev/
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
