Hi Drew,
On 05/ 1/12 07:07 AM, Drew Fisher wrote:
name can never be None because of the code in can_handle:
if element.get(cls.NAME_LABEL) is None:
return False
Good catch on the empty spaces. I'll toss a strip() call in there:
if not name.strip():
raise ...
Is "my test distro" a valid name? If so, a simple name.strip() will
remove the spaces.
If that's not a valid name, should we check for that as well?
Thanks,
--Karen
For testing, I've added a new unittest to trap on this new behavior.
If you need more testing with actual manifests, let me know.
-Drew
On 5/1/12 8:02 AM, Dermot McCluskey wrote:
Hi Drew,
85 name = element.get(cls.NAME_LABEL)
86 if not name:
87 raise ParsingError("distribution name must not be blank")
So, name can never be None and you just need to
check for name="", right? Should you also check
for name=" ", etc?
Also, what testing was done?
- Dermot
On 05/01/12 14:13, Drew Fisher wrote:
Good morning!
Could I please get a code review for the following bug:
7163019 <http://monaco.us.oracle.com/detail.jsf?cr=7163019> distro
name shouldn't be allowed to be blank
https://cr.opensolaris.org/action/browse/caiman/drewfish/7163019/webrev/
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
