Jack:
On 07/24/12 08:50 AM, Jack Schwartz wrote:
Hi Mary.
Looks pretty good. I suggest the following changes:
1) There could be some version of nose other than 0.11.3,so I would
say on line 41: "Need to comment out lines that start with
./nose-x.xx.x", delete line 43 and replace line 45 with "e.g."
Will fix.
2) Mention to install the nose package delivered with Solaris, if not
already installed:
pkg install library/python-2/nose
This is already mentioned in the list of packages to install in the
README at the beginning with Note #1.
3) Put the note of line 49 under line 51 as it deals with pylint.
Line-wrap and spacing need adjusting.
Will fix.
Thanks,
Jack
On 07/23/12 06:47 PM, Mary Ding wrote:
Hi:
Can I please get two reviews for CR 7185852:
CR: http://monaco.sfbay/detail.jsf?cr=7185852
Update tools/tests/README to mention removal of old easy-installed
nose so updated nose runs.
Web rev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7185852
Testing had been done this way:
Jack Schwartz had seen this on his machine. Nirmal and I had also
seen this on indiana-build. After we follow the README instructions
to comment out the older version of nose, the unit tests can run
without any problem.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
