LGTM too. Thanks Mary.
Martin
On 7/24/2012 4:01 PM, Mary Ding wrote:
Martin and Jack:
I had updated the webrev and you can take a look here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7185852
Thanks !!!!
On 07/24/12 01:40 PM, Mary Ding wrote:
Martin:
Thanks and I will fix these and send out code review later.
On 07/24/12 01:08 AM, Martin Widjaja wrote:
Hi Mary,
Just a couple of nits:
- line 38 : maybe get rid of the trailing colon from this line?
- line 49 and 70: I know you didn't originally create this, but if you can put the
"need to install...." on the next line, I think that'd be better than currently
really long line.
Otherwise, LGTM.
Martin
On 7/23/12 6:47 PM, Mary Ding wrote:
Hi:
Can I please get two reviews for CR 7185852:
CR: http://monaco.sfbay/detail.jsf?cr=7185852
Update tools/tests/README to mention removal of old easy-installed nose so
updated nose runs.
Web rev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7185852
Testing had been done this way:
Jack Schwartz had seen this on his machine. Nirmal and I had also seen this on
indiana-build. After we follow the README instructions to comment out the
older version of nose, the unit tests can run without any problem.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
