> On 27 Nov, 2018, at 4:10 pm, Jendaipou Palmei <jendaipoupal...@gmail.com> > wrote: > > We have made the changes in the code as suggested. > > Here is the diff after making the changes: > > https://github.com/Daipu/COBALT/commit/033db330287e2072bad94ac441f8aed774678a7d > > Additionally, we have also updated the values of 'Pincrement' and > 'Pdecrement' (parameters of BLUE) in ns-3 to match the ones used in the Cake > implementation in Linux. > > Does the diff look correct?
It does look like an improvement. How's the behaviour? NB: the decimal values used in the constants are not quite precise equivalents of the Linux values, since you have dropped some of the trailing digits. You could use (1./256) and (1./4096) to both make them precise and more human-readable. - Jonathan Morton _______________________________________________ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
