[ 
https://issues.apache.org/jira/browse/CB-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295233#comment-13295233
 ] 

Bryce Curtis commented on CB-913:
---------------------------------

I actually agree with the first thought of having bindButton/isButtonBound in 
CordovaInterface.  The reason is that it will support any button, so is 
flexible.  Also, there needs to be support in app.js, which calls methods on 
CordovaInterface.  The bindButton functionality is outside of the 
CordovaWebView, since the key events are sent to the Activity.

With that said, I suppose a second implementation is to use 
pluginManager.postMessage("bindButton", ...).  The question would be which is 
better, an API to provide function or messages?
                
> Refactor Key Press Overrides on Android
> ---------------------------------------
>
>                 Key: CB-913
>                 URL: https://issues.apache.org/jira/browse/CB-913
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 1.8.0
>            Reporter: Joe Bowser
>            Assignee: Filip Maj
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> Currently the Volume Up and Down events are in DroidGap.java.  While this is 
> fine for the general use case, it would be better if there was a utility 
> class that handled these events.  This would also allow us to implement the 
> GamePad API for the Google TV events, because Google in their infinite wisdom 
> chose to re-implement this instead of using the standard keyCodes for Up, 
> Down, Left and Right.
> This should fix existing bugs on Google TV, as well as make the code neater.  
> It also addresses CB-417.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to