----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/#review53837 -----------------------------------------------------------
kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/116949/#comment37754> If there's no icon just skip this parameter, please see the KAction API docs... kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/116949/#comment37755> Well, look how simple this loop can be using for(): QList<KexiWindow*> windowList; for (int i = 0; i < count(); i++) { KexiWindow* window = dynamic_cast<KexiMainWindow*>(KexiMainWindowIface::global())->windowForTab(i); if (window) { windowList.append(window); } } kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/116949/#comment37756> How about using: foreach (KexiWindow *window, windowList) { .... (no need to call removeAt() then) - Jarosław Staniek On March 23, 2014, 7:09 p.m., Vishwa Modi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116949/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 7:09 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > new KAction m_closeAction2 is added and closeAllTabs() function is added. > > > Diffs > ----- > > kexi/main/KexiMainWindow.h 3d76bb2 > kexi/main/KexiMainWindow.cpp e916281 > > Diff: https://git.reviewboard.kde.org/r/116949/diff/ > > > Testing > ------- > > > Thanks, > > Vishwa Modi > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
