> On March 23, 2014, 9:57 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 226 > > <https://git.reviewboard.kde.org/r/116949/diff/4/?file=256472#file256472line226> > > > > When there are zero tabs you're returning uninitialized value. > > Vishwa Modi wrote: > Will the function closeAllTabs() be called at all if there are zero tabs?
All scenarios should be covered :) We expect it returns true in this case. - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/#review53863 ----------------------------------------------------------- On March 23, 2014, 9:36 p.m., Vishwa Modi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116949/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 9:36 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > new KAction m_closeAction2 is added and closeAllTabs() function is added. > > > Diffs > ----- > > kexi/main/KexiMainWindow.h 3d76bb2 > kexi/main/KexiMainWindow.cpp e916281 > > Diff: https://git.reviewboard.kde.org/r/116949/diff/ > > > Testing > ------- > > > Thanks, > > Vishwa Modi > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
