Hi
I think this commit broke something in the build. If we go this patch
I am not sure if the apache-camel-<ver>-tests.jar is needed anymore
Hadrian
On Jul 2, 2008, at 9:33 AM, Willem Jiang wrote:
I am OK for that.
If we put the *Support class into camel-hamcrest module , this
module should be on the top of build.
Willem
James Strachan wrote:
I'd be tempted to move them into another jar; putting them into
camel-core feels wrong (particularly as they are mostly legacy
*Support classes now).
FWIW there's a little camel-hamcrest library with the hope of adding
more helper classes for testing; I wonder if we put them there for
now?
2008/7/2 Claus Ibsen <[EMAIL PROTECTED]>:
Hi
One of the problem could be that camel-core-1.4-SNAPSHOT-tests.jar
is 500kb and it include all the xxxTest classes that is used for
unit testing camel core itself + the xxxSupport classes.
What we want is to distribute a -tests.jar for end-users so they
can easily unit test their camel integrations.
William want to move the xxxSupport classes into camel-core itself
and not distribute any -tests.jar at all.
If doing this we should be aware that camel-core isn't bloating/
growing in size as the xxxSupport classes will reside with the
core classes also.
I will give a +1 if there are only very few xxxSupport classes.
Then end-users doesn't need to know how to add the test-jar in the
pom.xml for easy unit tests. It's just there with camel-core and
junit.jar.
But first of all we should probably try to fix the existing
generated camel-core-tests.jar to not include all the bloat, so it
will be 7kb or so, and a proppert unit test support jar for end-
users.
Med venlig hilsen
Claus Ibsen
......................................
Silverbullet
Skovsgårdsvænget 21
8362 Hørning
Tlf. +45 2962 7576
Web: www.silverbullet.dk
-----Original Message-----
From: James Strachan [mailto:[EMAIL PROTECTED]
Sent: 2. juli 2008 12:06
To: camel-dev@activemq.apache.org
Subject: Re: [VOTE] Release apache-camel-1.4
2008/7/2 Willem Jiang <[EMAIL PROTECTED]>:
Yes , this is much easier.
Now I am thinking we could remove the depency of camel-core-
test.jar for the
other camel modules by moving the *Support class from test
directory to
main directory.
Since there is no package name change or the API change , I'd
like to do it
before the release of Camel 1.4.0.
If no one object that I will do a quick refactoring for that.
I'm not quite sure why we're doing this - could you explain why?
I'm a
tad jetlagged so it could just be me being thick :)
The *Support classes are purely test dependencies so I'm not sure
why
removing camel-core-test.jar is a good thing.
--
James
-------
http://macstrac.blogspot.com/
Open Source Integration
http://open.iona.com
