Hi

I was about to get choked in my coffee this morning when the camel-commits new 
message count was rising to 44 ;)

Well first of great work. This part of the documentation really needed the 
brush up from The Man.

The dynamic router EIP:
http://cwiki.apache.org/CAMEL/dynamic-router.html
- should be added to release notes as a new EIP
- I would love a plain route example as well (no annotation usage)
- add that these new annotations are available as of Camel 1.5

http://cwiki.apache.org/CAMEL/bean-integration.html
- links to bean binding in the header itself, otherwise you need to find it in 
text teaser text


http://cwiki.apache.org/CAMEL/parameter-binding-annotations.html
- the list of annotations, we could add a new column indicating if it needs a 
parameter such as @Header and @Property. 

- This sentence: 
In the above you can now pass the Message.getJMSCorrelationID() as a parameter 
to the method (using the Type Converter to adapt the value to the type of the 
parameter).

Is a bit odd, as when reading it looks like that camel will automatically 
extract the Message.getJMSCorrelationID() in the first parameter, and the 
payload in the 2nd. But the above sentence "talks" about manually calling this 
method. Maybe for unit testing etc, you would manually call this method.

- Also this one:
Finally you don't need the @MessageDriven annotation; as the Camel route could 
describe which method to invoke.

Maybe adding a h4 header for the sample example without the @MessageDriven 
annotation, but still using bean binding

Eg I think you should add some more h4 headers to separate the example what you 
are doing.



I will get to this later. It's a great rewrite. Thanks a lot.






Med venlig hilsen
 
Claus Ibsen
......................................
Silverbullet
Skovsgårdsvænget 21
8362 Hørning
Tlf. +45 2962 7576
Web: www.silverbullet.dk
-----Original Message-----
From: James Strachan [mailto:[EMAIL PROTECTED] 
Sent: 1. oktober 2008 19:11
To: camel-dev@activemq.apache.org
Subject: [HeadsUp] Refactored the Bean Integration wiki pages

I've long disliked the crappy pages I hacked up a long time ago for
the various aspects of the bean integration. I've made an attempt to
try modularise it and fill in some missing details. Its certainly an
improvement, but I'm sure we can improve it some more. Its a kinda
crucial & major part of Camel so wanted to make sure we properly
explain it all correctly...

http://cwiki.apache.org/CAMEL/bean-integration.html

any thoughts?

-- 
James
-------
http://macstrac.blogspot.com/

Open Source Integration
http://open.iona.com

Reply via email to