2008/10/2 Claus Ibsen <[EMAIL PROTECTED]>: > Hi > > I was about to get choked in my coffee this morning when the camel-commits > new message count was rising to 44 ;) > > Well first of great work. This part of the documentation really needed the > brush up from The Man. > > The dynamic router EIP: > http://cwiki.apache.org/CAMEL/dynamic-router.html > - should be added to release notes as a new EIP
Done. > - I would love a plain route example as well (no annotation usage) > - add that these new annotations are available as of Camel 1.5 I've added the new annotations to the 1.5 release notes too > http://cwiki.apache.org/CAMEL/bean-integration.html > - links to bean binding in the header itself, otherwise you need to find it > in text teaser text Done - good catch :) > http://cwiki.apache.org/CAMEL/parameter-binding-annotations.html > - the list of annotations, we could add a new column indicating if it needs a > parameter such as @Header and @Property. Done > - This sentence: > In the above you can now pass the Message.getJMSCorrelationID() as a > parameter to the method (using the Type Converter to adapt the value to the > type of the parameter). > > Is a bit odd, as when reading it looks like that camel will automatically > extract the Message.getJMSCorrelationID() in the first parameter, and the > payload in the 2nd. But the above sentence "talks" about manually calling > this method. Maybe for unit testing etc, you would manually call this method. Yeah, have reworded that sentence a bit. > - Also this one: > Finally you don't need the @MessageDriven annotation; as the Camel route > could describe which method to invoke. Ditto > Maybe adding a h4 header for the sample example without the @MessageDriven > annotation, but still using bean binding > > Eg I think you should add some more h4 headers to separate the example what > you are doing. Done > I will get to this later. It's a great rewrite. Thanks a lot. You're most welcome :) -- James ------- http://macstrac.blogspot.com/ Open Source Integration http://open.iona.com
