[ 
https://issues.apache.org/activemq/browse/CAMEL-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48391#action_48391
 ] 

William Tam commented on CAMEL-1203:
------------------------------------

Przemyslaw, thanks for the great patch.   Keep it coming and yes participate 
wiki as well. 

Claus, here are some answers to your queries.  Thanks for the good catches.
* class MethodBasedRouter is not public.  It was on purpose.  Try to reduce the 
amount of  public API/class that we care about compatibility.
* I plan to add the HeaderFilterStrategy stuff to the binding.
* I changed to request.setReferrerRef("camel-restlet") 
* I think DefaultRestletBinding setting both IN and OUT body is a bug.  I 
changed it to:
{code}
        if (exchange.getPattern().isOutCapable()) {
            exchange.getOut().setBody(text);
        } else {
            LOG.warn("Exchange is incapable of receiving response");
        }
{code}
and the test does template.requestBody() instead.
* The Restlet server stops when the RestletComponent is started.
* Still need to add TRACE logging when client receive a response
* Producer buildUri() is now static
* Still need to add comments to parameters in RestletBinding.
* Consumer now uses ObjectHelper.wrapRuntimeCamelException for rethrowing
* We'll look into returning HTTP error 500 in case of consumer failure.  





> REST (Restlet based) component
> ------------------------------
>
>                 Key: CAMEL-1203
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1203
>             Project: Apache Camel
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Przemyslaw Budzik
>            Assignee: William Tam
>         Attachments: CAMEL-1203.patch, camel-restlet.patch
>
>
> This is the code I was talking with James which we are using in SubRecord. It 
> is minimalistic, but does its job for both consumer and producer and is very 
> easy to use. If you want could be a replacement for the current camel-rest 
> (or could be merged).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to