[
https://issues.apache.org/activemq/browse/CAMEL-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48400#action_48400
]
Claus Ibsen commented on CAMEL-1203:
------------------------------------
Great work guys. Nice component.
A few more comments
- LOG.warn("Exchange is incapable of receiving response");. You might wanna log
the exchange itself so end user can identify the exchange not being OUT.
"Exchange is incapable of receiving response: " + exchange
- CamelContextHelper.mandatoryLookup - mandatoryLookup will throw an exception
if not found in registry. So no need for == null check afterwards. Use just
lookup if you dont want the it to be mandatory. And this looks like to be the
case in your code where you create a default one if not found.
- WARN logging and then later creating a default content is not nice, what if
that is the use-case end users uses and now his log get's spammed with WARN logs
- copy paste bug in doStart doStop methods.
- And why are you using try .. catch in start/stop. I think it's wrong
especially in the start as the component will get started but it did thrown an
exception during startup. And thus could not work correctly.
- debug logging: attached methodRouter uriPattern. Should use a capital
starting letter. attached => Attached
Sorry about the wrap runtime error stuff
{code}
} catch (Exception e) {
LOG.error(e);
throw ObjectHelper.wrapRuntimeCamelException(e);
}
{code}
The throw ObjectHelper.wrapRuntimeCamelException(e); should *only* be used if
you are thrown a new exception. What you wanted was just to rethrow the
original exception. So use just: throw e instead
> REST (Restlet based) component
> ------------------------------
>
> Key: CAMEL-1203
> URL: https://issues.apache.org/activemq/browse/CAMEL-1203
> Project: Apache Camel
> Issue Type: New Feature
> Affects Versions: 2.0.0
> Reporter: Przemyslaw Budzik
> Assignee: William Tam
> Attachments: basic_auth.patch, CAMEL-1203.patch, camel-restlet.patch,
> status.patch
>
>
> This is the code I was talking with James which we are using in SubRecord. It
> is minimalistic, but does its job for both consumer and producer and is very
> easy to use. If you want could be a replacement for the current camel-rest
> (or could be merged).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
