Le 18/12/2011 14:08, Benedikt Meurer a écrit : > While we are at it: Can we have this patch applied to the Debian OCaml > package? This would (a) get OCaml running native on armhf and (b) get some > testing / feedback for the patch.
Your patch is way too monolithic. You cannot seriously expect anyone to apply it as it is. The git repository looks more sensible, but the history is kind of messy (e.g. one big initial import removing/duplicating arm.S, then later merge). My advice is to maintain a clean patch series (e.g. one patch for each new feature you advertise, or whatever logical split you see fit), in addition to publishing your working git repository. Please read: http://halobates.de/on-submitting-patches.pdf An acceptable workflow for me would be two git branches, one with your ongoing development, and another one starting from 3.12.1 release with a cleaned up and detailed history. Both would continuously have the same tree, but the cleaned-up one would be rebased if needed to keep the history clean. Then each commit of the cleaned-up branch would be reviewed and discussed separately as a candidate patch for upstream inclusion. All this can be done efficiently with git. What tests did you perform, by the way? Cheers, -- Stéphane -- Caml-list mailing list. Subscription management and archives: https://sympa-roc.inria.fr/wws/info/caml-list Beginner's list: http://groups.yahoo.com/group/ocaml_beginners Bug reports: http://caml.inria.fr/bin/caml-bugs
