SGTM for both. it's funny you mention 2. now. I had also forgotten to set the modtime (on my first CL iterations) for the zip downloader in the web UI that I did recently (and fixed it before submitting). Come to think of it, I probably did 1. too, I need to check now.
On 25 April 2017 at 09:38, Attila Tajti <[email protected]> wrote: > There are two problems with the zip download I'd like to mention here before > I create issues/CLs for them: > > 1. Paths in the zip file start with a slash. > > Paths inside zip files must be relative. > > Some zip extractors might not handle zip files with absolute paths properly, > the built in zip view in Windows 10 thinks there are no files in the > archive, but one can imagine badly written software might even extract the > files at the file system root. > > Changing the dirPath argument from "/" to "" in the initial calls to > zipHandler.blobList and zipHandler.blobsFromDir seems to have fixed the > problem on my end. > > 2. File ModTime is unset for files within the zip > > It would be nice to have the proper modtime from the permanode recorded as > file time inside the zip. > > -- > You received this message because you are subscribed to the Google Groups > "Camlistore" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
