Ack, thanks. On 26 April 2017 at 16:18, Attila Tajti <[email protected]> wrote: > Exactly. I have tip and it doesnt work with Chrome Version 58.0.3029.81 (up > to date) on Windows 10. I tried it with different permanodes (one and more > "file" permanodes, and permanodes with camliMembers). > > I can select items but clicking "Download" in the side bar yields "Form > submission canceled because the form is not connected" from goui.js:105. It > seems to be an error in the UI only, I see nothing in the server log. > > > On Wednesday, April 26, 2017 at 3:30:58 PM UTC+2, mpl wrote: >> >> Sorry, I'm confused since we're talking about two different issues at >> the same time. Let's forget about the publisher for a second here (I >> should have started a new e-mail thread). >> Is the download action of the web UI working for you on tip, or not? >> >> >> On 26 April 2017 at 15:24, Attila Tajti <[email protected]> wrote: >> > I suspect CL 9948 is not at fault in my case (dowloading zip from >> > publisher) >> > because https://camlistore-review.googlesource.com/9966 fixed it for me. >> > >> > Yes, I'm on c1eeefe (merge of publisher scheme fix) with only my >> > publisher >> > patches applied (zip relative path, zip file times, thumb ratio fix). >> > >> > On Wednesday, April 26, 2017 at 3:17:21 PM UTC+2, mpl wrote: >> >> >> >> wait, surely CL 9948 is not at fault here, right? >> >> So are you saying that on tip, with chrome on windows, you can't use >> >> the download action? >> >> >> >> On 26 April 2017 at 07:46, Attila Tajti <[email protected]> wrote: >> >> > My CLs were submitted as >> >> > >> >> > https://camlistore-review.googlesource.com/9966 app/publisher: use >> >> > relative >> >> > paths in filenames within zip >> >> > https://camlistore-review.googlesource.com/9967 publisher: add zip >> >> > download >> >> > file times >> >> > >> >> > How could I test your CL 9948? My idea was to select some elements on >> >> > the >> >> > web UI, and click download in the sidebar, but chrome tells me that >> >> > Form >> >> > submission canceled because the form is not connected >> >> > >> >> > >> >> > On Tuesday, April 25, 2017 at 6:05:16 PM UTC+2, mpl wrote: >> >> >> >> >> >> Yes, I know. That CL is the fix for what I was mentioning in my >> >> >> first >> >> >> reply, i.e. that I needed to double-check if I hadn't done for the >> >> >> web >> >> >> UI the same mistake you reported for the publisher. >> >> >> >> >> >> >> >> >> On 25 April 2017 at 16:42, Attila Tajti <[email protected]> wrote: >> >> >> > This seems to be something else. The zip handler I tried is >> >> >> > implemented >> >> >> > in >> >> >> > app/publisher/zip.go where I tried a similar approach with >> >> >> > strings.TrimPrefix. It worked, but I ended up with a different >> >> >> > approach >> >> >> > (use >> >> >> > an empty string as "root" instead of "/"). That might not work in >> >> >> > this >> >> >> > case. >> >> >> > >> >> >> > On Tuesday, April 25, 2017 at 4:24:01 PM UTC+2, mpl wrote: >> >> >> >> >> >> >> >> done, just in case: >> >> >> >> https://camlistore-review.googlesource.com/c/9948/ >> >> >> >> >> >> >> >> >> >> >> >> On 25 April 2017 at 15:11, Mathieu Lonjaret >> >> >> >> <[email protected]> >> >> >> >> wrote: >> >> >> >> > SGTM for both. >> >> >> >> > it's funny you mention 2. now. I had also forgotten to set the >> >> >> >> > modtime >> >> >> >> > (on my first CL iterations) for the zip downloader in the web >> >> >> >> > UI >> >> >> >> > that >> >> >> >> > I did recently (and fixed it before submitting). Come to think >> >> >> >> > of >> >> >> >> > it, >> >> >> >> > I probably did 1. too, I need to check now. >> >> >> >> > >> >> >> >> > >> >> >> >> > On 25 April 2017 at 09:38, Attila Tajti <[email protected]> >> >> >> >> > wrote: >> >> >> >> >> There are two problems with the zip download I'd like to >> >> >> >> >> mention >> >> >> >> >> here >> >> >> >> >> before >> >> >> >> >> I create issues/CLs for them: >> >> >> >> >> >> >> >> >> >> 1. Paths in the zip file start with a slash. >> >> >> >> >> >> >> >> >> >> Paths inside zip files must be relative. >> >> >> >> >> >> >> >> >> >> Some zip extractors might not handle zip files with absolute >> >> >> >> >> paths >> >> >> >> >> properly, >> >> >> >> >> the built in zip view in Windows 10 thinks there are no files >> >> >> >> >> in >> >> >> >> >> the >> >> >> >> >> archive, but one can imagine badly written software might even >> >> >> >> >> extract >> >> >> >> >> the >> >> >> >> >> files at the file system root. >> >> >> >> >> >> >> >> >> >> Changing the dirPath argument from "/" to "" in the initial >> >> >> >> >> calls >> >> >> >> >> to >> >> >> >> >> zipHandler.blobList and zipHandler.blobsFromDir seems to have >> >> >> >> >> fixed >> >> >> >> >> the >> >> >> >> >> problem on my end. >> >> >> >> >> >> >> >> >> >> 2. File ModTime is unset for files within the zip >> >> >> >> >> >> >> >> >> >> It would be nice to have the proper modtime from the permanode >> >> >> >> >> recorded >> >> >> >> >> as >> >> >> >> >> file time inside the zip. >> >> >> >> >> >> >> >> >> >> -- >> >> >> >> >> You received this message because you are subscribed to the >> >> >> >> >> Google >> >> >> >> >> Groups >> >> >> >> >> "Camlistore" group. >> >> >> >> >> To unsubscribe from this group and stop receiving emails from >> >> >> >> >> it, >> >> >> >> >> send >> >> >> >> >> an >> >> >> >> >> email to [email protected]. >> >> >> >> >> For more options, visit https://groups.google.com/d/optout. >> >> >> > >> >> >> > -- >> >> >> > You received this message because you are subscribed to the Google >> >> >> > Groups >> >> >> > "Camlistore" group. >> >> >> > To unsubscribe from this group and stop receiving emails from it, >> >> >> > send >> >> >> > an >> >> >> > email to [email protected]. >> >> >> > For more options, visit https://groups.google.com/d/optout. >> >> > >> >> > -- >> >> > You received this message because you are subscribed to the Google >> >> > Groups >> >> > "Camlistore" group. >> >> > To unsubscribe from this group and stop receiving emails from it, >> >> > send >> >> > an >> >> > email to [email protected]. >> >> > For more options, visit https://groups.google.com/d/optout. >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups >> > "Camlistore" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> > an >> > email to [email protected]. >> > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Camlistore" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
