Agreed. https://camlistore-review.googlesource.com/10026 should fix 2. Not sure it's the correct Reacty way to do that, but it seems to be doing the job. PTAL. I'll see about 1. afterwards.
On 28 April 2017 at 15:51, Attila Tajti <[email protected]> wrote: > Please note that there are at least 2 bugs if I'm not mistaken: > > 1. Navigation is enabled in the first place > 2. Navigation doesn't update permanode attrs UI > > Fixing #1 would solve this issue but it is #2 that seems really dangerous. > > Thank you > > > Attila > > On 28.04.2017 15:44:51, Mathieu Lonjaret <[email protected]> wrote: > > I see, thanks for the repro. > > We should probably at least block navigation when we're editing. I'm > gonna look into it. > > > On 28 April 2017 at 12:30, Attila Tajti wrote: >> I think I've found the source of this bug. >> >> Pressing cursor right/left on the web UI with an edit box within the >> permanode tab switches ref to the next/last permanode without loading the >> attributes of the new permanode. >> >> Steps to reproduce: >> >> Select any permanode on the UI >> Switch to Permanode tab >> Set focus to any edit box (attribute name or value) >> Press cursor left/right >> Ref in URL/search bar changes >> >> >> Camlistore is version c1eeefe from 2017-04-24 with some publisher patches >> applied. >> >> >> On Wednesday, April 26, 2017 at 8:26:28 AM UTC+2, Attila Tajti wrote: >>> >>> I changed a permanode on the web UI that used to be: >>> >>> $ camtool describe -at 2017-04-26T00:00:00Z >>> sha1-ab849aceb01bcb5050108d9bf571e2bee9115605 >>> { >>> "meta": { >>> "sha1-ab849aceb01bcb5050108d9bf571e2bee9115605": { >>> "blobRef": "sha1-ab849aceb01bcb5050108d9bf571e2bee9115605", >>> "camliType": "permanode", >>> "size": 562, >>> "permanode": { >>> "attr": { >>> "camliMember": [ >>> "...list of image permanodes...", >>> ], >>> "title": [ >>> "2017-Farsang" >>> ] >>> }, >>> "modtime": "2017-04-25T11:02:49.0272824Z" >>> } >>> } >>> } >>> } >>> >>> I edited the title on the web UI (removed the slash from it) and noticed >>> saving takes some time. Then I realized that another permanode was >>> changed >>> instead: >>> >>> $ camtool describe -at 2017-04-26T 05:50:00Z >>> sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab >>> { >>> "meta": { >>> "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab": { >>> "blobRef": "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab", >>> "camliType": "permanode", >>> "size": 562, >>> "permanode": { >>> "attr": { >>> "camliMember": [ >>> "...same list of image permanodes as above...", >>> ], >>> "camliPath:2017-Egerszalók": [], >>> "camliPath:2017-Prag": [], >>> "camliRoot": [], >>> "title": [ >>> "2017 Farsang" >>> ] >>> }, >>> "modtime": "2017-04-26T05:48:22Z" >>> } >>> } >>> } >>> } >>> >>> It used to be my publish root: >>> >>> $ camtool describe -at 2017-04-26T00:00:00Z >>> sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab >>> { >>> "meta": { >>> "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab": { >>> "blobRef": "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab", >>> "camliType": "permanode", >>> "size": 562, >>> "permanode": { >>> "attr": { >>> "camliPath:2017-Egerszalók": [ >>> "sha1-8d816ea7c965aedea71491c57fd13aaad86a0eb7" >>> ], >>> "camliPath:2017-Prag": [ >>> "sha1-79593689d3c8ee7c394a99107e791f4793be9597" >>> ], >>> "camliRoot": [ >>> "publisher-pics" >>> ], >>> "title": [ >>> "Publish Root" >>> ] >>> }, >>> "modtime": "2017-04-24T10:36:42Z" >>> } >>> } >>> } >>> } >>> >>> I wonder if having the camlistore web UI open in the browser while >>> updating it on the server could have resulted in this? >>> >>> Since this was a problem with my publish root I wanted to fix the problem >>> ASAP so I don't know what version of the web UI was in use in the >>> browser, >>> it could have been either 19972a9 or the 20170405 monthly build. >>> >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Camlistore" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Camlistore" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/camlistore/uDxRGMnRbds/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Camlistore" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
