Ah I see your point now and I totally agree. Arrows should move the cursor when we're editing. Let's reopen the issue.
On Dec 20, 2017 16:47, "Attila Tajti" <[email protected]> wrote: > I discovered this when editing the title of a permanode. Maybe made a typo > or forgot to capitalize something so I wanted to move the cursor to the > part of text in question. But this happens also with the main search box. > > Is trying to move the cursor within an edit box with the arrow keys > considered to be navigation by mistake? > > I'm not a UI expert, but IMO if an edit box is focused certain one would > expect to have certain events (such as arrow keys with or without > modifiers) handled by this edit box only without side effects. > > Btw, is there a shortcut to leave the edit box? Eg. in Youtube or Gmail > esc does it, but in the Web UI it resets the view. > > > On Wednesday, December 20, 2017 at 4:18:57 PM UTC+1, mpl wrote: >> >> Yes, in https://camlistore-review.googlesource.com/c/camlistore/+/11806 >> I fixed a bug that is related to the issue, and that needed fixing >> anyway: >> with this change, if you're now in the middle of editing an attribute >> and you navigate away, the edit is not "transferred" anymore to the >> page of the prev/next permanode. This prevents you from applying the >> attribute to the wrong permanode, like it could have happened by >> accident before. >> My contention is that fixing this bug made navigating behave >> correctly, and therefore it is not necessary, or even desired, to >> block navigation when we're editing. Because if you navigate by >> mistake there is no other consequence than you having lost whatever >> edit you had started, which seems fair. >> Do you disagree? >> >> On 20 December 2017 at 09:43, Attila Tajti <[email protected]> wrote: >> > Editing permanode attrs on the web UI still has a problem: cursor >> left/right >> > still navigates away from the current permanode (and therefore the >> current >> > edit box). >> > >> > Camlistore: 2017-12-07-29693e2cc5+ >> > Go: linux/amd64 go1.9.1, cgo=false >> > djpeg: djpeg available >> > >> > There were two problems: >> > #922 (the important one) ensure that changes do not propagate to the >> new >> > permanode when navigating >> > #923 (annoyance) navigation should not be enabled when an edit box is >> active >> > >> > As far as I understand, both CLs ended up fixing #922 and not #923 >> > >> > https://github.com/camlistore/camlistore/issues/922 >> > https://camlistore-review.googlesource.com/10026 >> > >> > https://github.com/camlistore/camlistore/issues/923 >> > https://camlistore-review.googlesource.com/c/camlistore/+/11806 >> > >> > >> > On Wednesday, April 26, 2017 at 8:26:28 AM UTC+2, Attila Tajti wrote: >> >> >> >> I changed a permanode on the web UI that used to be: >> >> >> >> $ camtool describe -at 2017-04-26T00:00:00Z >> >> sha1-ab849aceb01bcb5050108d9bf571e2bee9115605 >> >> { >> >> "meta": { >> >> "sha1-ab849aceb01bcb5050108d9bf571e2bee9115605": { >> >> "blobRef": "sha1-ab849aceb01bcb5050108d9bf571e2bee9115605", >> >> "camliType": "permanode", >> >> "size": 562, >> >> "permanode": { >> >> "attr": { >> >> "camliMember": [ >> >> "...list of image permanodes...", >> >> ], >> >> "title": [ >> >> "2017-Farsang" >> >> ] >> >> }, >> >> "modtime": "2017-04-25T11:02:49.0272824Z" >> >> } >> >> } >> >> } >> >> } >> >> >> >> I edited the title on the web UI (removed the slash from it) and >> noticed >> >> saving takes some time. Then I realized that another permanode was >> changed >> >> instead: >> >> >> >> $ camtool describe -at 2017-04-26T 05:50:00Z >> >> sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab >> >> { >> >> "meta": { >> >> "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab": { >> >> "blobRef": "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab", >> >> "camliType": "permanode", >> >> "size": 562, >> >> "permanode": { >> >> "attr": { >> >> "camliMember": [ >> >> "...same list of image permanodes as above...", >> >> ], >> >> "camliPath:2017-Egerszalók": [], >> >> "camliPath:2017-Prag": [], >> >> "camliRoot": [], >> >> "title": [ >> >> "2017 Farsang" >> >> ] >> >> }, >> >> "modtime": "2017-04-26T05:48:22Z" >> >> } >> >> } >> >> } >> >> } >> >> >> >> It used to be my publish root: >> >> >> >> $ camtool describe -at 2017-04-26T00:00:00Z >> >> sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab >> >> { >> >> "meta": { >> >> "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab": { >> >> "blobRef": "sha1-cd3f555efa12741575c35e0477ca71e5fbf0eaab", >> >> "camliType": "permanode", >> >> "size": 562, >> >> "permanode": { >> >> "attr": { >> >> "camliPath:2017-Egerszalók": [ >> >> "sha1-8d816ea7c965aedea71491c57fd13aaad86a0eb7" >> >> ], >> >> "camliPath:2017-Prag": [ >> >> "sha1-79593689d3c8ee7c394a99107e791f4793be9597" >> >> ], >> >> "camliRoot": [ >> >> "publisher-pics" >> >> ], >> >> "title": [ >> >> "Publish Root" >> >> ] >> >> }, >> >> "modtime": "2017-04-24T10:36:42Z" >> >> } >> >> } >> >> } >> >> } >> >> >> >> I wonder if having the camlistore web UI open in the browser while >> >> updating it on the server could have resulted in this? >> >> >> >> Since this was a problem with my publish root I wanted to fix the >> problem >> >> ASAP so I don't know what version of the web UI was in use in the >> browser, >> >> it could have been either 19972a9 or the 20170405 monthly build. >> >> >> >> >> > -- >> > You received this message because you are subscribed to the Google >> Groups >> > "Camlistore" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an >> > email to [email protected]. >> > For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Camlistore" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
