Very nice, Mike. I've committed it. Thanks!
- Jamis
On Jan 17, 2007, at 1:23 AM, Mike Bailey wrote:
I tracked down the source of a problem today related to
overriding :restart in .caprc.
As of Capistrano 1.3.0 you cannot override standard tasks
from .caprc because it is
loaded before the standard tasks (see lines 262 and 265)
The expected behaviour for dotfiles is to override program
defaults. I have attached a patch
to re-order the two.
I also added some code to load a systemwide capistrano config/
recipe definition, before loading
the users dotfile. This could benefit users on a shared host (such
as deployment server) and
is pretty standard in the unix world.
In an attempt to be Windows friendly I have taken a stab at a good
location for
the systemwide config. Shout if there is a better choice than ENV
["SystemRoot"]
So the order of loading (and overloading) would go:
1. standard capistrano tasks (in capistrano gem)
2. system wide tasks (/etc/capistrano.conf)
3. user tasks (~/.caprc)
4. recipe files specified on command line with (-f, --file)
5. finally default recipes (e.g. 'config/deploy.rb') if they exist
I've also removed the --caprc command line option as it's redundant
when users
can specify a file using (-f, --file)
Jamis, does this patch look OK to be applied?
Mike
<capistrano_dotfile_fix_and_sysconf.patch>
--~--~---------~--~----~------------~-------~--~----~
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/capistrano
-~----------~----~----~----~------~----~------~--~---
