+1 Ruwan
Samisa Abeysinghe wrote: > The BAM publishers on trunk are to undergo change to use the eventing > component. > > The current code use the old way of eventing. Hence it is no point > reviewing this code, rather the new code once the eventing module is > integrated needs to be reviewed on trunk. > > Also, note that, we have not synced the branch with the trunk. There > were too many changes on the branch, that was prohibiting to sync both > at once while in the release cycle. We will first sync 2.0.2 which is > the most latest with 2.0.3 and then with trunk, and then the changes > to eventing component etc will take place. Then only it will be ready > for review, the publishers. > > Also, we have not yet incorporated the previous review > outcomes, because of the release deadline. We will have to do that > before 1.0.1 of BAM is released. > > Samisa... > > On Sat, Jan 2, 2010 at 7:49 AM, Ruwan Linton <[email protected] > <mailto:[email protected]>> wrote: > > Folks, > > I had a look at the BAM code on the trunk (while fixing the maven > structure, I had to :-) ), first of all it doesn't seem to be in sync > with the branch or rest of the carbon trunk. I had to fix a few > compilation errors. > > Please note that some fixes are sort of hacks, just to get the code > compiling, where a BAM person with a better understanding has to fix > them properly. I put TODO comments on those places. > > Most importantly I see a lot of boiler plate code on the > bam-data-publishers module, where we can abstract out most of them > into > a top level abstract class. By looking at the current BAM trunk, users > who are writing a data publisher has to write a lot of unwanted code, > well we could provide a basic impl of those and users could overwrite > that if they want to change the behavior. > > I propose a code review of BAM soon after we start. WDYT? > > Thanks, > Ruwan > > -- > Ruwan Linton > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb > WSO2 <http://wso2.org/esb%0AWSO2> Inc.; http://wso2.org > email: [email protected] <mailto:[email protected]>; cell: +94 77 341 3097 > blog: http://blog.ruwan.org > > > > _______________________________________________ > Carbon-dev mailing list > [email protected] <mailto:[email protected]> > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > -- > Samisa Abeysinghe > Director, Engineering - WSO2 Inc. > > http://www.wso2.com/ - "The Open Source SOA Company" > ------------------------------------------------------------------------ > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > -- Ruwan Linton Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org email: [email protected]; cell: +94 77 341 3097 blog: http://blog.ruwan.org _______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
