Senaka Fernando wrote: > > > On Sat, Jan 2, 2010 at 10:05 PM, Ruwan Linton <[email protected] > <mailto:[email protected]>> wrote: > > OK, lets review the registry code after the BAM then ;-) > > > :-)... Sure thing. By the way, I forgot to mention... :-).. The 2.x > code is nearly the same as what is found in Synapse... :D... Yeah, I know you copied it from Synapse. :-D
Thanks, Ruwan > > Thanks, > Senaka. > > > > Thanks, > Ruwan > > Senaka Fernando wrote: > > > > > > On Sat, Jan 2, 2010 at 7:29 PM, Samisa Abeysinghe > <[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > Also, the use of "eventing component" is supposed to fix this > > problem of duplicated code pointed out in the two event message > > receivers. In 2.x family, there is no eventing component, but in > > 3.x. > > > > While 3.x would solve the duplication, thanks to the eventing > > component, refactoring this on the 2.x branch would mean to take > > trunk code to branch, which breaks backward compatibility on > 2.x. > > > > This is one of the reasons that it was not possible to do this > > right, hence the focus on get it to work. > > > > > > I agree with Samisa here. Even for the Registry, the Eventing > > implementation in 2.x is not nicely done, as the focus was to get it > > to work properly (which we have achieved). The proper implementation > > which allows multiple components to share the same codebase is > > introduced for 3.x, having done a thorough evaluation on how it > should > > be implemented, based on the experiences we had in 2.x. > > > > Thanks, > > Senaka. > > > > > > Samisa... > > > > > > On Sat, Jan 2, 2010 at 7:19 PM, Samisa Abeysinghe > <[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > I agree there can be improvement. I am the one who wrote > this > > code. I just got a copy from registry eventing, got it > working > > for service stats, and then copied that to mediation stats. > > > > There was no time to do more refactoring before the release. > > > > Samisa... > > > > On Sat, Jan 2, 2010 at 9:40 AM, Ruwan Linton > <[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > BTW: even on the 2.0.2 branch I see a boiler plate code, > > which can be > > improved. There is no point in reviewing that > branch, so, > > when ever the > > code on the trunk is ready for review lets do a > review to > > improve those. > > > > For example have a look at the classes [1] and [2], > > > > [1] - > > > > https://svn.wso2.org/repos/wso2/branches/carbon-platform/2.0.2/carbon-components/bam-data-publishers/org.wso2.carbon.bam.data.publisher.servicestats/src/main/java/org/wso2/carbon/bam/data/publisher/servicestats/eventing/receivers/StatisticsEventingMessageReceiver.java > > [2] - > > > > https://svn.wso2.org/repos/wso2/branches/carbon-platform/2.0.2/carbon-components/bam-data-publishers/org.wso2.carbon.bam.data.publisher.mediationstats/src/main/java/org/wso2/carbon/bam/data/publisher/mediationstats/eventing/receivers/StatisticsEventingMessageReceiver.java > > > > Thanks, > > Ruwan > > > > Ruwan Linton wrote: > > > +1 > > > > > > Ruwan > > > > > > Samisa Abeysinghe wrote: > > > > > >> The BAM publishers on trunk are to undergo change to > > use the eventing > > >> component. > > >> > > >> The current code use the old way of eventing. > Hence it > > is no point > > >> reviewing this code, rather the new code once the > > eventing module is > > >> integrated needs to be reviewed on trunk. > > >> > > >> Also, note that, we have not synced the branch > with the > > trunk. There > > >> were too many changes on the branch, that was > > prohibiting to sync both > > >> at once while in the release cycle. We will first > sync > > 2.0.2 which is > > >> the most latest with 2.0.3 and then with trunk, and > > then the changes > > >> to eventing component etc will take place. Then > only it > > will be ready > > >> for review, the publishers. > > >> > > >> Also, we have not yet incorporated the previous > review > > >> outcomes, because of the release deadline. We > will have > > to do that > > >> before 1.0.1 of BAM is released. > > >> > > >> Samisa... > > >> > > >> On Sat, Jan 2, 2010 at 7:49 AM, Ruwan Linton > > <[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>> > > >> <mailto:[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>>> wrote: > > >> > > >> Folks, > > >> > > >> I had a look at the BAM code on the trunk (while > > fixing the maven > > >> structure, I had to :-) ), first of all it > doesn't > > seem to be in sync > > >> with the branch or rest of the carbon trunk. > I had > > to fix a few > > >> compilation errors. > > >> > > >> Please note that some fixes are sort of > hacks, just > > to get the code > > >> compiling, where a BAM person with a better > > understanding has to fix > > >> them properly. I put TODO comments on those > places. > > >> > > >> Most importantly I see a lot of boiler plate code > > on the > > >> bam-data-publishers module, where we can abstract > > out most of them > > >> into > > >> a top level abstract class. By looking at the > > current BAM trunk, users > > >> who are writing a data publisher has to write > a lot > > of unwanted code, > > >> well we could provide a basic impl of those and > > users could overwrite > > >> that if they want to change the behavior. > > >> > > >> I propose a code review of BAM soon after we > start. > > WDYT? > > >> > > >> Thanks, > > >> Ruwan > > >> > > >> -- > > >> Ruwan Linton > > >> Technical Lead & Product Manager; WSO2 ESB; > > http://wso2.org/esb > > >> WSO2 <http://wso2.org/esb%0AWSO2> Inc.; > http://wso2.org > > >> email: [email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>> > > <mailto:[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>>; cell: +94 > > 77 341 3097 > > >> blog: http://blog.ruwan.org > > >> > > >> > > >> > > >> _______________________________________________ > > >> Carbon-dev mailing list > > >> [email protected] > <mailto:[email protected]> <mailto:[email protected] > <mailto:[email protected]>> > > <mailto:[email protected] > <mailto:[email protected]> <mailto:[email protected] > <mailto:[email protected]>>> > > >> > > > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > >> > > >> > > >> > > >> > > >> -- > > >> Samisa Abeysinghe > > >> Director, Engineering - WSO2 Inc. > > >> > > >> http://www.wso2.com/ - "The Open Source SOA Company" > > >> > > > ------------------------------------------------------------------------ > > >> > > >> _______________________________________________ > > >> Carbon-dev mailing list > > >> [email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>> > > >> > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > >> > > >> > > > > > > > > > > > > > > > -- > > Ruwan Linton > > Technical Lead & Product Manager; WSO2 ESB; > > http://wso2.org/esb > > WSO2 <http://wso2.org/esbWSO2> Inc.; http://wso2.org > > email: [email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>; cell: +94 > > 77 341 3097 > > blog: http://blog.ruwan.org > > > > > > > > _______________________________________________ > > Carbon-dev mailing list > > [email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>> > > > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > > > > > > -- > > Samisa Abeysinghe > > Director, Engineering - WSO2 Inc. > > > > http://www.wso2.com/ - "The Open Source SOA Company" > > > > > > > > > > -- > > Samisa Abeysinghe > > Director, Engineering - WSO2 Inc. > > > > http://www.wso2.com/ - "The Open Source SOA Company" > > > > _______________________________________________ > > Carbon-dev mailing list > > [email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>> > > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > > > > > > -- > > Senaka Fernando > > Software Engineer > > WSO2 Inc. > > E-mail: [email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>; Mobile: +94 77 > 322 1818 > > > > http://www.wso2.com/ - "The Open Source SOA Company" > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Carbon-dev mailing list > > [email protected] <mailto:[email protected]> > > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > -- > Ruwan Linton > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb > WSO2 <http://wso2.org/esb%0AWSO2> Inc.; http://wso2.org > email: [email protected] <mailto:[email protected]>; cell: +94 77 341 3097 > blog: http://blog.ruwan.org > > > > _______________________________________________ > Carbon-dev mailing list > [email protected] <mailto:[email protected]> > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > -- > Senaka Fernando > Software Engineer > WSO2 Inc. > E-mail: [email protected] <mailto:[email protected]>; Mobile: +94 77 322 1818 > > http://www.wso2.com/ - "The Open Source SOA Company" > ------------------------------------------------------------------------ > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > -- Ruwan Linton Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org email: [email protected]; cell: +94 77 341 3097 blog: http://blog.ruwan.org _______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
