If you run the IDEA plugin, it will generate an HTML for you. See the
attachment.

Thanks,
Senaka.

On Sat, Aug 7, 2010 at 12:14 PM, Afkham Azeez <[email protected]> wrote:

> Attaching FindBugs reports. Most of the errors are related to the generated
> Axis2 stub code.
>
> Does anyone know of a way to convert the FindBugs reports to HTML or PDF?
>
> Azeez
>
>
> On Thu, Aug 5, 2010 at 9:25 AM, Afkham Azeez <[email protected]> wrote:
>
>> All of these have been fixed. I will send hte FindBugs report shortly.
>>
>> Thanks
>> Azeez
>>
>> On Wed, Aug 4, 2010 at 4:08 PM, Supun Kamburugamuva <[email protected]>wrote:
>>
>>> Code Review Done By: Afkham Azeez
>>>
>>> Components Reviewed:
>>>
>>> webapp-mgt in Carbon Components
>>> org.wso2.carbon.server in Carbon Core
>>>
>>> Here are the notes
>>>
>>> 1. Setting the weather a web is faulty should be revisited.
>>>
>>> 2. We should consider throwing a more specific exceptions in
>>> TomcatGenericWEbappsDeployer. At the moment it is throwing the generic
>>> Exception.
>>>
>>> 3. A stopped web app should return HTTP status code 503 instead of 404.
>>>
>>> 4. At the moment it is using Java file operations which may not work
>>> in Windows environemt. It better to use commons IO for handling file
>>> operations.
>>>
>>> 5. We should us a carbon exception in WebApplication class
>>>
>>> 6. WebApplication second constructor should be revisited as it may not be
>>> used
>>>
>>> 7. There are some places where string literals are used instead of
>>> constants
>>>
>>> Thanks,
>>> Supun..
>>>
>>> _______________________________________________
>>> Carbon-dev mailing list
>>> [email protected]
>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>
>>
>>
>> --
>> Afkham Azeez
>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
>> Lean . Enterprise . Middleware
>> Member; Apache Software Foundation; http://www.apache.org/
>> email: [email protected] cell: +94 77 3320919
>> blog: http://blog.afkham.org
>> twitter: http://twitter.com/afkham_azeez
>> linked-in: http://lk.linkedin.com/in/afkhamazeez
>>
>
>
>
> --
> Afkham Azeez
> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
> Lean . Enterprise . Middleware
> Member; Apache Software Foundation; http://www.apache.org/
> email: [email protected] cell: +94 77 3320919
> blog: http://blog.afkham.org
> twitter: http://twitter.com/afkham_azeez
> linked-in: http://lk.linkedin.com/in/afkhamazeez
>
> _______________________________________________
> Carbon-dev mailing list
> [email protected]
> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
Senaka Fernando
Associate Technical Lead
WSO2 Inc.
E-mail: senaka AT wso2.com;  Mobile: +94 77 322 1818

http://www.wso2.com/ - "Lean . Enterprise . Middleware"
Title: FindBugs Report

FindBugs Report

Produced using FindBugs1.3.9.

Project:

Metrics

168 lines of code analyzed, in 1 classes, in 1 packages.

Metric Total Density*
High Priority Warnings NaN
Medium Priority Warnings NaN
Total Warnings 0 0.00

(* Defects per Thousand lines of non-commenting source statements)



Summary

Warning Type Number
Performance Warnings 2
Total 2



Warnings

Click on each warning link to see a full description of the issue, and details of how to resolve it.

Performance Warnings

Warning Priority Details
Inefficient use of keySet iterator instead of entrySet iterator Medium

Method org.wso2.carbon.core.multitenancy.utils.TenantAxisUtils.cleanupTenants(ConfigurationContext, BundleContext, long) makes inefficient use of keySet iterator instead of entrySet iterator


In file TenantAxisUtils.java, line 316
In class org.wso2.carbon.core.multitenancy.utils.TenantAxisUtils
In method org.wso2.carbon.core.multitenancy.utils.TenantAxisUtils.cleanupTenants(ConfigurationContext, BundleContext, long)
At TenantAxisUtils.java:[line 316]

Inefficient use of keySet iterator instead of entrySet iterator Medium

Method org.wso2.carbon.core.multitenancy.utils.TenantAxisUtils.initializeTenantTransports(ConfigurationContext) makes inefficient use of keySet iterator instead of entrySet iterator


In file TenantAxisUtils.java, line 197
In class org.wso2.carbon.core.multitenancy.utils.TenantAxisUtils
In method org.wso2.carbon.core.multitenancy.utils.TenantAxisUtils.initializeTenantTransports(ConfigurationContext)
At TenantAxisUtils.java:[line 197]





Warning Types

Inefficient use of keySet iterator instead of entrySet iterator

This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.



_______________________________________________
Carbon-dev mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to