We had the second session of this yesterday, where we looked at, 1. CarbonTomcatRealm 2. Tomcat valves 3. Webapp lazy loading 4. Securing webapps
Azeez On Wed, Aug 4, 2010 at 4:08 PM, Supun Kamburugamuva <[email protected]> wrote: > Code Review Done By: Afkham Azeez > > Components Reviewed: > > webapp-mgt in Carbon Components > org.wso2.carbon.server in Carbon Core > > Here are the notes > > 1. Setting the weather a web is faulty should be revisited. > > 2. We should consider throwing a more specific exceptions in > TomcatGenericWEbappsDeployer. At the moment it is throwing the generic > Exception. > > 3. A stopped web app should return HTTP status code 503 instead of 404. > > 4. At the moment it is using Java file operations which may not work > in Windows environemt. It better to use commons IO for handling file > operations. > > 5. We should us a carbon exception in WebApplication class > > 6. WebApplication second constructor should be revisited as it may not be > used > > 7. There are some places where string literals are used instead of > constants > > Thanks, > Supun.. > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > -- Afkham Azeez Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, Lean . Enterprise . Middleware Member; Apache Software Foundation; http://www.apache.org/ email: [email protected] cell: +94 77 3320919 blog: http://blog.afkham.org twitter: http://twitter.com/afkham_azeez linked-in: http://lk.linkedin.com/in/afkhamazeez
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
