On Tue, Dec 14, 2010 at 8:56 AM, Hiranya Jayathilaka <[email protected]>wrote:
> Hi, > > On Tue, Dec 14, 2010 at 8:29 AM, Danushka Menikkumbura > <[email protected]>wrote: > >> In that case isn't it the user's responsibility to provide a complete, >>> fully qualified JNDI object name? We can of course make it easier by >>> providing some recommendations in the UI depending on the selected JMS >>> provider. For instance when Qpid is stated as the broker, we can provide a >>> text field partially filled with "connectionfactory." to specify the >>> connection factory name. >>> >> >> Hiranya, >> >> I think this is what Manjula is concerned about. He had an offline chat >> with me yesterday regarding this. The easiest thing would be to let the user >> provide fully-qualified JNDI names which is not that user-friendly IMO. So >> rather than providing a partially filled text box, we an let user inter JNDI >> names and we dorequired appending/prefixing internally. >> > > IMO this approach is wrong for the following reasons: > > 1. The actual JNDI name is always hidden from the user. We take the value > entered by the user and internally modify it the way we see fit. > 2. We cannot possibly support all the JMS brokers available in this manner. > With some brokers the user will have to enter full qualified names anyway. > 3. If these prefix values change in the broker implementations, we have to > change our code > 4. We have to handle the case where the user enters the full qualified name > 5. Some brokers have weird edge cases. For instance ActiveMQ sometimes > requires a prefix like "dynamicQueues/" or "dynamicTopics/". We cannot > handle such cases in our code in a clean manner. > > My suggestion is to let the user enter the full qualified name and make it > easier for Qpid (making the most common case simpler). We can add the prefix > in case of Qpid but we should clearly let the user know that. > I think we have to let user to select which JMS provider they are going to add. That way, we can add a prefix for connection factory name for Qpid. And if there are another properties needed as dynamicQueues, we can add them too. And initial context factory, provider URL and connection factory name will be used in UI so the user is not confusing with names like poviderUrlName. Thank you. > > Thanks, > Hiranya > > >> >> Danushka >> >> >>> >>> If we stick to the current approach, please change the url name parameter >>> to something more meaningful like "JNDI Object Name Prefix". >>> >> >> >> _______________________________________________ >> Carbon-dev mailing list >> [email protected] >> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Hiranya Jayathilaka > Senior Software Engineer; > WSO2 Inc.; http://wso2.org > E-mail: [email protected]; Mobile: +94 77 633 3491 > Blog: http://techfeast-hiranya.blogspot.com > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Manjula Rathnayaka Software Engineer WSO2, Inc. Mobile:+94 77 743 1987
_______________________________________________ Carbon-dev mailing list [email protected] https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
