[carbon-emacs:1032] Re: fullscreen: frames jumping

[David Reitter]

On 15 Jul 2008, at 10:08, Vebjorn Ljosa wrote:

  I had missed the fact that
fullscreen_hook can be called even when the fullscreen frame parameter

fix a little; new patch is attached.

does not change (e.g., from x_set_font). I have cleaned/shortened your

Yes, looks good to me.

I was editing the patch directly with rather little oversight of the surrounding code...

This does not address the problem with certain (variable-width?) fonts

and the frame not actually covering the whole screen,

yesterday.

This problem should be fixed with the patch that Seiji checked in for me

I assume that's the GNU Emacs CVS, right?
Thanks

and neither does
it disable frame movement by the toolbar.

important.

Since I'm on 10.4, I can't reproduce this. I don't think it's terribly

I do, so I'll check how we can disable it.

A bigger problem, however, is that turning tool-bar-mode on and off

or too tall.  I will look into that.

while in fullscreen mode causes the frame to resize and become too short

iTerm turns off the toolbar for fullscreen mode.
That would solve both problems.

It would be nice if this stuff could be fixed so the code can be
checked into Emacs 23 before the feature freeze.

I didn't understand from the previous discussion what kind of Mac
support Emacs 23 has.  Carbon?  Cocoa?

Good point.
Cocoa is getting merged this week.
Carbon is dysfunctional in 23.

Now that you mention it, I believe it's a waste of time to patch 23/ Carbon, but we should see how the patch can be adapted (or rewritten) for the Cocoa port. I'm not sure if the new port doesn't already support fullscreen.

Vebjorn, have you already signed papers with the FSF?

No, but I'd be happy to.  Are there instructions somewhere?

- D

I'll look that up; I guess if we're not checking in your code, it's not a pressing matter.

smime.p7s
Description: S/MIME cryptographic signature