On Wed, Feb 17, 2010 at 9:54 AM, Marvin Addison <[email protected]> wrote: >> Commited on rev47927 >> CAS providers are performing authentication too late in the >> Application event pipeline. >> Substantional reworking of Forms based CasAuthenticationModule in >> order to fit more nicely into the .NET framework. >> Patch provided by Scott Holodak.
I think we all have the same goals. First and foremost, a first-class CAS Client for the .NET Framework, built and supported by the Jasig community, as the official Jasig .NET Cas client. That's been my goal from the beginning. We have an internal deadline that is driving our current work, which is why we may seem a little hurried. ScottH is doing the heavy lifting here and is doing a fantastic job. It benefits us and the community to have him do this work directly in the Jasig svn repo. > What is going on here? The _discuss_ part of this matter is still > ongoing and we already have a commit? If you feel that the process for commits needs to be more formalized, we should discuss that. However, there are several posts on the email list, a JIRA issue, a patch, comments on the JIRA issue (made by Marvin), as well as a code review by the original author (Bill). It seemed reasonable to commit the current state so that ScottH could continue his work with a reasonable check point rather then ending up with one big massive commit. (it was big enough already!) We could go back and branch if someone would like to take this work in another direction, but I doubt that will be necessary. > I strongly suggest we abide by > some guidelines that are both fair and common practice in a software > development project: > > - The developer assigned to an issue is responsible for commits > - The assigned developer may reassign an issue to another developer > without discussion > - If Developer A wants to handle an issue assigned Developer B, it > should be handled via request (email, on-issue, list, IM, etc) Traditionally, the developer responsible for a code base in Jasig is the original author, designate, or delegate. With regards to the CasAuthenicationModule specifically, I believe that is me, in conjunction with design input from ScottH[1] as well as code improvements from Marvin and Catherine. Jasig projects have generally be a little loose in regards to this, mostly because folks knew and trusted each other prior to collaborating. [1] https://lists.wisc.edu/read/messages?id=3113950#3113950 > > The bottom line is more communication. While I'm convinced Scott H's > approach is the right one, and I admitted as much on NETC-6, I had > hoped for a little more dialogue before we started blowing away > existing code. Additionally, I had wanted to do the merge myself to > ensure we had a clean revision history. I had previously stated on the list that I would shepherd in ScottH's changes until he got committer access, and there were no objections. I was unaware of your intentions to do a merge, in any case all the revision history is there. Seems like we've hit an inflection point in this project with regards to roles/responsibilities that are perhaps best settle in person (preferably over a beer or two, or three[2]), or at least over the phone. I'd be happy to participate in any discussion to help smooth over any perceived issues and make sure we're all on the same page. This project needs to get a release out and if there are willing and able hands (ScottH) we need to let him work. If there are no objections, he should be given committer access to continue to improve the Forms-based AuthN Module specifically and the general code base, based on JIRA issues and appropriate levels of discussion. I'd like to continue to improve code base in place at Jasig unless there is a reasonable objection. I'd really like to see an RC by the Jasig conference. Best Regards, Bill [2] or four, or...oh never mind. > > M > > -- > You are currently subscribed to [email protected] as: [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
