On Wed, Jan 11, 2012 at 5:01 PM, William G. Thompson, Jr. <[email protected]>wrote:
> Folks, > > cas-server-integration-ehcache tests are now running on master and the > code generally has been brought into compliance with cas code style. > Woohoo! > > The tests are running about 5 minutes on my machine. Still need to > look into why and if this expected. Thoughts on how long is too long > for tests in general? > Probably a bit too long for a single test.I would think we would want a test to run in less than 30 seconds if possible (though I just made up that number) > > I've also noticed that the EhCacheTicketRegistry depends on ticket > prefix (i.e. ST, TGT) to determine which cache to deal with. This > seems brittle to me and likely would break with SAML style artifact > id. Would love some thoughts or perspective on this. At first glance > I'm not seeing the need for two different caches. > > Yes, it would break. I'd have to look at the code a bit more to determine if its required. Typically they have different expiration policies, so that might be why (since EhCache is a cache) Cheers, Scott > I will continue to review and improve the module. > > Best, > Bill > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
