Bill, I could look into the Ehcache tests tomorrow if you want me to.
Cheers, Dmitriy. Sent from my iPhone On Jan 11, 2012, at 17:15, "William G. Thompson, Jr." <[email protected]> wrote: > On Wed, Jan 11, 2012 at 5:04 PM, Scott Battaglia > <[email protected]> wrote: >> >> On Wed, Jan 11, 2012 at 5:01 PM, William G. Thompson, Jr. <[email protected]> >> wrote: >>> >>> Folks, >>> >>> cas-server-integration-ehcache tests are now running on master and the >>> code generally has been brought into compliance with cas code style. >> >> >> Woohoo! >> >>> >>> >>> The tests are running about 5 minutes on my machine. Still need to >>> look into why and if this expected. Thoughts on how long is too long >>> for tests in general? >> >> >> Probably a bit too long for a single test.I would think we would want a test >> to run in less than 30 seconds if possible (though I just made up that >> number) > > Here's a benchmark from my machine for comparison: > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > ------------------------------------------------------------------------ > [INFO] Jasig Central Authentication Service .................. SUCCESS > [1.212s] > [INFO] JA-SIG CAS Core ....................................... SUCCESS > [1:00.060s] > [INFO] JA-SIG CAS Web Application ............................ SUCCESS > [1.395s] > [INFO] JA-SIG CAS Generic Support ............................ SUCCESS > [0.841s] > [INFO] JA-SIG CAS JDBC Support ............................... SUCCESS > [0.218s] > [INFO] JA-SIG CAS LDAP Support ............................... SUCCESS > [1.863s] > [INFO] JA-SIG CAS Legacy Support ............................. SUCCESS > [0.684s] > [INFO] JA-SIG CAS OpenId Support ............................. SUCCESS > [1.067s] > [INFO] JA-SIG CAS RADIUS Support ............................. SUCCESS > [0.350s] > [INFO] JA-SIG CAS SPNEGO/NTLM Support ........................ SUCCESS > [2.727s] > [INFO] JA-SIG CAS Trusted User Support ....................... SUCCESS > [0.834s] > [INFO] JA-SIG CAS X.509 Client Certificate Support ........... SUCCESS > [2.113s] > [INFO] JA-SIG CAS JBoss Cache Integration .................... SUCCESS > [19.368s] > [INFO] JA-SIG CAS BerkeleyDB Integration ..................... SUCCESS > [3.679s] > [INFO] JA-SIG CAS Memcached Integration ...................... SUCCESS > [0.201s] > [INFO] Jasig CAS EHCache Integration ......................... SUCCESS > [4:48.397s] > [INFO] JA-SIG CAS Restlet Integration ........................ SUCCESS > [0.241s] > [INFO] Jasig CAS - Uber WAR .................................. SUCCESS > [0.214s] > [INFO] CAS Documentation ..................................... SUCCESS > [0.148s] > [INFO] > ------------------------------------------------------------------------ > > I'm not totally convinced the tests are actually functioning as expected... > >> >> >>> >>> >>> I've also noticed that the EhCacheTicketRegistry depends on ticket >>> prefix (i.e. ST, TGT) to determine which cache to deal with. This >>> seems brittle to me and likely would break with SAML style artifact >>> id. Would love some thoughts or perspective on this. At first glance >>> I'm not seeing the need for two different caches. >>> >> Yes, it would break. I'd have to look at the code a bit more to determine >> if its required. Typically they have different expiration policies, so that >> might be why (since EhCache is a cache) >> >> Cheers, >> Scott >> >> >> >>> >>> I will continue to review and improve the module. >>> >>> Best, >>> Bill >>> >>> -- >>> You are currently subscribed to [email protected] as: >>> [email protected] >>> To unsubscribe, change settings or access archives, see >>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> >> -- >> You are currently subscribed to [email protected] as: [email protected] >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/cas-dev > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
