Some recent commits have added additional properties/constructors to a
couple ExpirationPolicy components that will be leveraged in the default
Spring contexts for 3.5 and presumably future releases that change the
default time interval from ms to s:
https://github.com/Jasig/cas/commit/11709f8294beb4cb1ffd699ca5cce6c14ef4383f
https://github.com/Jasig/cas/commit/a08f601e71b0abf98f5cda666144bce09c957638
While this may provide consistency for the expiration policies that are
configured by default, the other ExpirationPolicy components still use
milliseconds. Moreover, we have used ms fairly consistently for time
intervals throughout the CAS codebase.
The intent to increase convenience and clarity of time intervals for
deployers is laudable and reasonable, but the changes above don't go
nearly far enough. If tight timelines are limiting the scope of changes
to a few components, then it would be better to wait until we have the
time and resources to develop a flexible time interval facility and
apply it consistently. XML durations,
http://www.w3.org/TR/xmlschema-2/#duration, are one of a number of
reasonable standards we might consider.
I strongly recommend that we do no further harm with capricious
component interface changes and tackle the issue thoroughly and
consistently after the 3.5 release. I propose a Jira issue to track
that effort and link it with the two issues behind the changes above.
M
--
You are currently subscribed to cas-dev@lists.jasig.org as:
arch...@mail-archive.com
To unsubscribe, change settings or access archives, see
http://www.ja-sig.org/wiki/display/JSG/cas-dev
