Thanks Jérôme, it was nice to have your input. By the way, i didn't check,
i think the openId client described in the website you pointed me to is
incorrect : CAS implementing the dumb openid mode, the client should check
the authentication succes (extra http request). But i think it does not,
otherwise it wouldn't have worked for me or for you with such a client
(because of the openid handler mapping order problem).

And thanks for checking the \r\n problem, i was going to look at this this
week end. Now with our joined efforts, i think we can say the cas openid
support module is fixed :)

Maybe i could become commiter on the cas project, provide this fix and why
not (it's something that i'd like to do, but don't know if it's something
wanted in CAS), implement the smart openid protocol, which is preferred to
the dumb mode (and saves a request :) ).

Frederic

On Fri, Mar 30, 2012 at 8:54 AM, jleleu <lel...@gmail.com> wrote:

> Hi Frédéric,
>
> You did a great job !
>
> I encounter also the problem with \r\n : I find a solution by replacing :
>  return Base64.encodeBase64String(sha1.doFinal(value.getBytes()));
> with :
>  return new String(Base64.encodeBase64(sha1.doFinal(value.getBytes())),
> "UTF-8");
> on line 72 of the OpenIdService class (in cas-server-support-openid
> module).
>
> Best regards,
> Jérôme
>
> --
> You are currently subscribed to cas-dev@lists.jasig.org as:
> esnault.frede...@gmail.com
> To unsubscribe, change settings or access archives, see
> http://www.ja-sig.org/wiki/display/JSG/cas-dev
>

-- 
You are currently subscribed to cas-dev@lists.jasig.org as: 
arch...@mail-archive.com
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-dev

Reply via email to