Technically if there is no replacement for LdapServiceRegistry it should probably be deprecated before being removed.
On Fri, May 24, 2013 at 9:25 AM, Marvin S. Addison <marvin.addi...@gmail.com > wrote: > Planning to drop the following classes: >> >> - BindLdapAuthenticationHandler.**java >> - DigestMd5DirContextAuthenticat**ionStrategy.java >> - FastBindLdapAuthenticationHand**ler.java >> - RemoteIpLookupCredentialsToPri**ncipalResolver.java >> - SpringLdapUtils.java >> - CredentialsToLDAPAttributePrin**cipalResolver.java >> - BindLdapAuthenticationHandlerT**ests.java >> - BindTestConfig.java >> - FastBindLdapAuthenticationHand**lerTests.java >> - CredentialsToLDAPAttributePrin**cipalResolverTests.java >> - LdapUtilTests.java >> > > Should be safe to delete the above since we have replacement components > based on ldaptive or use an alternative test strategy. I would argue we > need to spend some energy on some LDAP test infrastructure. Daniel > recommended we check out com.unboundid.ldap.listener.**InMemoryDirectoryServer > as a test fixture we could spin up for unit tests. I'm still pretty certain > we need some additional test fixtures for platform specific functionality > like AD password expiration policy tests, but hopefully we can start small > and build up. > > > Converting the following classes: >> >> - LdapConnectionMonitor.java (Renamed) >> - PoolingLdapConnectionMonitor.**java (Renamed) >> > > Maybe git considers them renamed, but they are more correctly quivalent > components using ldaptive. > > - AbstractLdapPersonDirectoryCre**dentialsToPrincipalResolver.**java >> - AbstractLdapUsernamePasswordAu**thenticationHandler.java >> > > This can be removerd using same rationale as above list of components to > be deleted. > > > Not sure about the following: >> >> - LdapServiceRegistryDao.java >> > > +1 to drop. If anyone has a use case for an LDAP store, we'll accept > contributions based on ldaptive. > > > M > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: > scott.battag...@gmail.com > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/**display/JSG/cas-dev<http://www.ja-sig.org/wiki/display/JSG/cas-dev> > -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
