Sounds good.  Can you open a JIRA request for this?
http://www.ja-sig.org/issues

Thanks!
Scott


On Fri, Nov 13, 2009 at 9:29 AM, Serban Balamaci <[email protected]>wrote:

>
> Hello. I've downloaded cas client 3.1.9. I haven't been able to checkout
> from
> svn the sources, maybe it looks different there but:
>
> In class AuthenticationFilter we have at line 90:
>        final String serviceUrl = constructServiceUrl(request, response);
>        final Assertion assertion = session != null ? (Assertion)
> session.getAttribute(CONST_CAS_ASSERTION) : null;
>
>        if (assertion != null) {
>            filterChain.doFilter(request, response);
>            return;
>        }
>
>
> I would think there could be a small performance improvement in checking
> first that the session has the attributes and after that construct the
> final String serviceUrl = constructServiceUrl(request, response);
> if it's necessary.
> I've put my logs in debug mode and for every resource in my page I see the
> "serviceUrl generated: " + url.
>
> What do you think?
> Thank you.
> --
> View this message in context:
> http://n4.nabble.com/Cas-client-maybe-small-performance-improvements-tp620992p620992.html
> Sent from the CAS Users mailing list archive at Nabble.com.
>
> --
> You are currently subscribed to [email protected] as:
> [email protected]
> To unsubscribe, change settings or access archives, see
> http://www.ja-sig.org/wiki/display/JSG/cas-user
>

-- 
You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-user

Reply via email to