Thanks! I'll target this for our next release. Cheers, Scott
On Mon, Nov 16, 2009 at 12:53 PM, Serban Balamaci <[email protected]>wrote: > > It worked from home. Created CAS-100. > Thank you. > > > Serban Balamaci wrote: > > > > Hello Scott, > > > > > > > > I will, but it seems the request for > > http://www.ja-sig.org/issues/browse/CAS > > times out. > > > > I have no other problem with the www.jasig.org <http://www.jasig.org/> > > site > > though. > > > > Is there a problem with the server? I will try later again. > > > > > > > > Cheers. > > > > > > > > _____ > > > > From: Scott Battaglia-2 [via Jasig] > > [mailto:[email protected]<ml-node%[email protected]> > ] > > Sent: 16 noiembrie 2009 17:38 > > To: Serban Balamaci > > Subject: Re: [cas-user] Cas client maybe small performance improvements > > > > > > > > Sounds good.B Can you open a JIRA request for this? > > http://www.ja-sig.org/issues > > > > Thanks! > > Scott > > > > > > > > On Fri, Nov 13, 2009 at 9:29 AM, Serban Balamaci <[hidden email] > > <http://n4.nabble.com/user/SendEmail.jtp?type=node&node=622192&i=0> > > > wrote: > > > > > > Hello. I've downloaded cas client 3.1.9. I haven't been able to checkout > > from > > svn the sources, maybe it looks different there but: > > > > In class AuthenticationFilter we have at line 90: > > B B B B final String serviceUrl = constructServiceUrl(request, response); > > B B B B final Assertion assertion = session != null ? (Assertion) > > session.getAttribute(CONST_CAS_ASSERTION) : null; > > > > B B B B if (assertion != null) { > > B B B B B B filterChain.doFilter(request, response); > > B B B B B B return; > > B B B B } > > > > > > I would think there could be a small performance improvement in checking > > first that the session has the attributes and after that construct the > > final String serviceUrl = constructServiceUrl(request, response); > > if it's necessary. > > I've put my logs in debug mode and for every resource in my page I see > the > > "serviceUrl generated: " + url. > > > > What do you think? > > Thank you. > > -- > > View this message in context: > > > http://n4.nabble.com/Cas-client-maybe-small-performance-improvements-tp62099 > > 2p620992.html > > Sent from the CAS Users mailing list archive at Nabble.com. > > > > -- > > You are currently subscribed to [hidden email] > > <http://n4.nabble.com/user/SendEmail.jtp?type=node&node=622192&i=1> as: > > [hidden email] > > <http://n4.nabble.com/user/SendEmail.jtp?type=node&node=622192&i=2> > > To unsubscribe, change settings or access archives, see > > http://www.ja-sig.org/wiki/display/JSG/cas-user > > > > > > > > -- > > > > > > You are currently subscribed to [hidden email] > > <http://n4.nabble.com/user/SendEmail.jtp?type=node&node=622192&i=3> as: > > [hidden email] > > <http://n4.nabble.com/user/SendEmail.jtp?type=node&node=622192&i=4> > > > > > > To unsubscribe, change settings or access archives, see > > http://www.ja-sig.org/wiki/display/JSG/cas-user > > > > > > > > _____ > > > > View message @ > > > http://n4.nabble.com/Cas-client-maybe-small-performance-improvements-tp62099 > > 2p622192.html > > To unsubscribe from Cas client maybe small performance improvements, > click > > < (link removed) > > pQGFzZi5yb3w2MjA5OTJ8MjA0NTQyNTQ1NA==> here. > > > > > > > > > > > > -- > View this message in context: > http://n4.nabble.com/Cas-client-maybe-small-performance-improvements-tp620992p622272.html > Sent from the CAS Users mailing list archive at Nabble.com. > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-user > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-user
