Hi, Jason,
Thanks for the details! This kind of commentary would be great to
include in the commit log message.
See "git help commit" (the DISCUSSION part)...
Though not required, it's a good idea to begin the commit
message with a single short (less than 50 character) line
summarizing the change, followed by a blank line and then a
more thorough description. Tools that turn commits into
email, for example, use the first line on the Subject: line
and the rest of the commit in the body.
On Jun 23, 2010, at 23:53 , Jason Manley wrote:
The first one (the biggest one) involves the twiddle coefficients
and matlab's understanding of "i" and "j" as sqrt(-1) for complex
numbers. This one's been fixed and should be checked-in. See
earlier emails for details.
FWIW, I've noticed another related problem in the pfb_fir and
pfb_fir_real blocks. The mask callbacks for the TotalTaps parameter
of these blocks assign and use a variable named "size".
Unfortunately, this seems to wind up in the global workspace and
overrides the built-in "size" function. This can have all kinds of
potential effects, but the one I've seen involves the simulink
"Counter Free-Running" block. It can't evaluate its initialization
commands because it uses something like "size(x)" to get the size of
variable "x". Since size has been redefined as a variable, "size(x)"
is interpreted as an attempt to reference an element of the variable
"size", but because variable "size" is a scalar you get an "exceeds
matrix dimensions" error. Then you're stuck until you "clear size"
from your workspace.
I could change this myself, but if Andrew is making additional
changes to casper_library.mdl, perhaps he can change this variable's
name himself to something else that won't conflict so he can avoid
having to merge the model file. I think the "size" variable is used
only within the callback, so it should be a pretty localized change.
I thought these callbacks executed in their own namespace, but
apparently not.
FWIW, many of the FFT blocks have a similar, though commented out,
use of a variable named "size".
Dave
